langgenius/dify-plugin-daemon
1
0
Fork 0
mirror of https://github.com/langgenius/dify-plugin-daemon.git synced 2026-07-21 17:25:23 -04:00
Code Issues 111 Packages Projects Releases 10 Wiki Activity

[PR #559] [CLOSED] fix: support lowercase proxy environment variables fallback #581

New Issue
Closed
opened 2026-02-16 01:16:23 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 01:16:23 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify-plugin-daemon/pull/559
Author: @fghpdf
Created: 1/7/2026
Status: ❌ Closed

Base: main ← Head: fix/issue-18752-proxy-env-fallback

📝 Commits (10+)

  • 785329c feat: Agent plugin add features tag
  • ee0b250 Merge branch 'main' into cache-endpoint-and-plugin-install
  • 6af7000 use AutoTypeWithGetter
  • b6a6f11 BUGFIX: fix AutoGetWithGetter will never hit cache issue.
  • 68d3537 remove debug log
  • e77c014 BUGFIX: fix AutoGetWithGetter will never hit cache issue.
  • 441ddea fix: the list entity unmashal
  • 25a620a Merge pull request #140 from zxfishhack/fix-never-hit-cache
  • 8679b68 test plugin server with mysql
  • 2495b10 fix: handle the feature field JSON marshal

📊 Changes

1 file changed (+3 additions, -9 deletions)

View changed files

📝 internal/types/app/default.go (+3 -9)

📄 Description

Description

This PR adds support for lowercase proxy environment variables as a fallback when uppercase versions are not set.

Changes

  • Added fallback logic in SetDefault() method to check lowercase http_proxy, https_proxy, and no_proxy when uppercase versions (HTTP_PROXY, HTTPS_PROXY, NO_PROXY) are empty
  • Added new helper function setDefaultStringFromEnv() to read from environment variables

Fixes

Fixes langgenius/dify#18752

Testing

  • Code compiles successfully
  • Follows the same pattern as other configuration defaults in the codebase

Behavior

  • If HTTP_PROXY is set, it will be used (backward compatible)
  • If HTTP_PROXY is empty but http_proxy is set, http_proxy will be used
  • Same logic applies to HTTPS_PROXY/https_proxy and NO_PROXY/no_proxy

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify-plugin-daemon/pull/559 **Author:** [@fghpdf](https://github.com/fghpdf) **Created:** 1/7/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/issue-18752-proxy-env-fallback` --- ### 📝 Commits (10+) - [`785329c`](https://github.com/langgenius/dify-plugin-daemon/commit/785329c55ee1cd3e148504978baa622a2576408e) feat: Agent plugin add features tag - [`ee0b250`](https://github.com/langgenius/dify-plugin-daemon/commit/ee0b2503ddb5a0b037c808e128e09bf9a461c22e) Merge branch 'main' into cache-endpoint-and-plugin-install - [`6af7000`](https://github.com/langgenius/dify-plugin-daemon/commit/6af7000bdec90cc48e1a851e653b250987059d87) use AutoTypeWithGetter - [`b6a6f11`](https://github.com/langgenius/dify-plugin-daemon/commit/b6a6f113f326de94bccf2f47c3dc65d3890f5686) BUGFIX: fix AutoGetWithGetter will never hit cache issue. - [`68d3537`](https://github.com/langgenius/dify-plugin-daemon/commit/68d353795924589bac70dfd45b57ee56cfafb445) remove debug log - [`e77c014`](https://github.com/langgenius/dify-plugin-daemon/commit/e77c014208688e2c249290176e8f2ad498dadad2) BUGFIX: fix AutoGetWithGetter will never hit cache issue. - [`441ddea`](https://github.com/langgenius/dify-plugin-daemon/commit/441ddeaec5c5d228d61380e65e4872fb8b3fc8b9) fix: the list entity unmashal - [`25a620a`](https://github.com/langgenius/dify-plugin-daemon/commit/25a620a9a74a1497de85fed0a97501cbc00f5ff4) Merge pull request #140 from zxfishhack/fix-never-hit-cache - [`8679b68`](https://github.com/langgenius/dify-plugin-daemon/commit/8679b68ddd19a51dff31b84d149fe757743afb32) test plugin server with mysql - [`2495b10`](https://github.com/langgenius/dify-plugin-daemon/commit/2495b10bde180d546d3fad8896ff1a06cd94e673) fix: handle the feature field JSON marshal ### 📊 Changes **1 file changed** (+3 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `internal/types/app/default.go` (+3 -9) </details> ### 📄 Description ## Description This PR adds support for lowercase proxy environment variables as a fallback when uppercase versions are not set. ## Changes - Added fallback logic in `SetDefault()` method to check lowercase `http_proxy`, `https_proxy`, and `no_proxy` when uppercase versions (`HTTP_PROXY`, `HTTPS_PROXY`, `NO_PROXY`) are empty - Added new helper function `setDefaultStringFromEnv()` to read from environment variables ## Fixes Fixes langgenius/dify#18752 ## Testing - Code compiles successfully - Follows the same pattern as other configuration defaults in the codebase ## Behavior - If `HTTP_PROXY` is set, it will be used (backward compatible) - If `HTTP_PROXY` is empty but `http_proxy` is set, `http_proxy` will be used - Same logic applies to `HTTPS_PROXY`/`https_proxy` and `NO_PROXY`/`no_proxy` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 01:16:23 -05:00
yindo closed this issue 2026-02-16 01:16:23 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Windows
bug
cmd
documentation
enhancement
go
good first issue
plugin-daemon
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify-plugin-daemon#581
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?