langgenius/dify-plugin-daemon
1
0
Fork 0
mirror of https://github.com/langgenius/dify-plugin-daemon.git synced 2026-07-21 17:25:23 -04:00
Code Issues 111 Packages Projects Releases 10 Wiki Activity

[PR #604] fix: plugin install context canceled by detaching from HTTP request c… #609

New Issue
Open
opened 2026-02-16 01:16:30 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 01:16:30 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify-plugin-daemon/pull/604
Author: @IthacaDream
Created: 2/7/2026
Status: 🔄 Open

Base: main ← Head: fix/context-canceled-problem

📝 Commits (1)

  • 5f0b09d fix: plugin install context canceled by detaching from HTTP request context

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 internal/service/install_plugin.go (+2 -0)

📄 Description

Fixes #603

Description

Summary

Plugin installation/upgrade runs asynchronously after returning a task ID, but previously reused the HTTP request context (c.Request.Context()). When the handler returned, the context was canceled, causing uv sync (started via exec.CommandContext) to fail with context canceled.

Changes

  • Detach background install/upgrade goroutines from request cancellation using context.WithoutCancel(ctx).
  • Preserve tracing context via log.EnsureTrace(...) for downstream spans/logs.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • Other

Essential Checklist

Testing

  • I have tested the changes locally and confirmed they work as expected
  • I have added unit tests where necessary and they pass successfully

Bug Fix (if applicable)

  • I have used GitHub syntax to close the related issue (e.g., Fixes #123 or Closes #123)

Additional Information

Local plugin dependency installation (uv sync / uv pip install) no longer fails immediately due to premature context cancellation.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify-plugin-daemon/pull/604 **Author:** [@IthacaDream](https://github.com/IthacaDream) **Created:** 2/7/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/context-canceled-problem` --- ### 📝 Commits (1) - [`5f0b09d`](https://github.com/langgenius/dify-plugin-daemon/commit/5f0b09d020b9097fc0a9d1bbcfc026a3b74aff98) fix: plugin install context canceled by detaching from HTTP request context ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `internal/service/install_plugin.go` (+2 -0) </details> ### 📄 Description Fixes #603 ## Description #### Summary Plugin installation/upgrade runs asynchronously after returning a task ID, but previously reused the HTTP request context (c.Request.Context()). When the handler returned, the context was canceled, causing uv sync (started via exec.CommandContext) to fail with context canceled. #### Changes - Detach background install/upgrade goroutines from request cancellation using context.WithoutCancel(ctx). - Preserve tracing context via log.EnsureTrace(...) for downstream spans/logs. ## Type of Change - [x] Bug fix - [ ] New feature - [ ] Refactor - [ ] Performance improvement - [ ] Other ## Essential Checklist ### Testing - [x] I have tested the changes locally and confirmed they work as expected - [x] I have added unit tests where necessary and they pass successfully ### Bug Fix (if applicable) - [x] I have used GitHub syntax to close the related issue (e.g., `Fixes #123` or `Closes #123`) ## Additional Information Local plugin dependency installation (uv sync / uv pip install) no longer fails immediately due to premature context cancellation. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-16 01:16:30 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Windows
bug
cmd
documentation
enhancement
go
good first issue
plugin-daemon
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify-plugin-daemon#609
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?