Files
Xiyuan Chen b979ebbecd fix: clean up ServerlessRuntime record and cache on plugin uninstall (#749)
* fix: delete ServerlessRuntime record on plugin uninstall when refs reach zero

* refactor: expose ClearServerlessRuntimeCache as public method on PluginManager

* fix: clear serverless runtime cache on full plugin uninstall (ENG-474)

* fix: clean up ServerlessRuntime record and cache on plugin upgrade when refs reach zero
2026-06-01 14:32:13 +08:00

96 lines
2.7 KiB
Go

package plugin_manager
import (
"fmt"
"time"
"github.com/langgenius/dify-plugin-daemon/internal/core/serverless_runtime"
"github.com/langgenius/dify-plugin-daemon/internal/db"
"github.com/langgenius/dify-plugin-daemon/internal/types/models"
"github.com/langgenius/dify-plugin-daemon/pkg/entities/plugin_entities"
"github.com/langgenius/dify-plugin-daemon/pkg/utils/cache"
"github.com/langgenius/dify-plugin-daemon/pkg/utils/cache/helper"
)
const (
PLUGIN_SERVERLESS_CACHE_KEY = "serverless:runtime:%s"
)
func (p *PluginManager) getServerlessRuntimeCacheKey(
identity plugin_entities.PluginUniqueIdentifier,
) string {
return fmt.Sprintf(PLUGIN_SERVERLESS_CACHE_KEY, identity.String())
}
func (p *PluginManager) getServerlessPluginRuntime(
identity plugin_entities.PluginUniqueIdentifier,
) (plugin_entities.PluginLifetime, error) {
model, err := p.getServerlessPluginRuntimeModel(identity)
if err != nil {
return nil, err
}
// FIXME: get declaration
declaration, err := helper.CombinedGetPluginDeclaration(identity, plugin_entities.PLUGIN_RUNTIME_TYPE_SERVERLESS)
if err != nil {
return nil, err
}
// init runtime entity
runtimeEntity := plugin_entities.PluginRuntime{
Config: *declaration,
}
runtimeEntity.InitState()
// convert to plugin runtime
pluginRuntime := serverless_runtime.ConstructServerlessPluginRuntime(
p.config,
declaration,
model,
p.mediaBucket,
identity,
)
return pluginRuntime, nil
}
func (p *PluginManager) getServerlessPluginRuntimeModel(
identity plugin_entities.PluginUniqueIdentifier,
) (*models.ServerlessRuntime, error) {
// check if plugin is a serverless runtime
runtime, err := cache.Get[models.ServerlessRuntime](
p.getServerlessRuntimeCacheKey(identity),
)
if err != nil && err != cache.ErrNotFound {
return nil, fmt.Errorf("unexpected error occurred during fetch serverless runtime cache: %v", err)
}
if err == cache.ErrNotFound {
runtimeModel, err := db.GetOne[models.ServerlessRuntime](
db.Equal("plugin_unique_identifier", identity.String()),
)
if err == db.ErrDatabaseNotFound {
return nil, fmt.Errorf("plugin serverless runtime not found: %s", identity.String())
}
if err != nil {
return nil, fmt.Errorf("failed to load serverless runtime from db: %v", err)
}
cache.Store(p.getServerlessRuntimeCacheKey(identity), runtimeModel, time.Minute*30)
runtime = &runtimeModel
} else if err != nil {
return nil, fmt.Errorf("failed to load serverless runtime from cache: %v", err)
}
return runtime, nil
}
func (p *PluginManager) ClearServerlessRuntimeCache(
identity plugin_entities.PluginUniqueIdentifier,
) error {
_, err := cache.Del(p.getServerlessRuntimeCacheKey(identity))
return err
}