Files
dify-plugin-daemon/internal/tasks/install_plugin_utils.go
Yeuoly 888ad788bc refactor: plugin lifecycle control panel (#499)
* refactor: introduce local plugin control panel and cleanup environment setup process

* fix: args

* refactor: new local runtime

* temp: stash work for refactor on RemotePluginServer

* refactor: unify local runtime lifetime and sperate init environment process

* chore: add missing files

* stash

* refactor: local plugin lifetime control

* refactor: complete installation process of control panel

* refactor: adapt service layer to new controlpanel

* refactor: pluginManager.Install

* fix: add routine wrap to InstallServerless, avoid blocking main thread

* feat: reinstall serverless runtime

* chore: add comments to Reinstall and update confusing naming

* refactor: unify install plugin service

* refactor: add labels to debugging runtime

* refactor: add getters to plugin manager

* refactor: split install service to decode/install_task/install service

* ???

* refactor: adapt controllers

* refactor: session write

* refactor: session runtime

* Refine install task orchestration (#501)

* refactor: installing task

* refactor cluster management, decouple lifetime management and cluster

* fix cli test command

* fix: cleanup TODO comments and implement GracefulStop for instance

* feat: add logger to control panel

* fix: multiple nil references

* refactor: better lifetime control

* refactor: better cycle interval

* fix(LocalPluginRuntime): prevent returning err when it's not  error

* fix: avoid adding empty PipExtraArgs

* fix: missing errors in Environment init

* fix: add truncateMessage to avoid db explosion

* cleanup: better lifecycle management

* fix: init status at the beginning of installation

* optimize: GracefulStop for pluginInstance

* refactor: tests

* refactor: centralize routine labels (#504)

* cleanup: RoutineKey

* fix: init routine pool

* fix: correctly handle cluster register error

* fix: memory leak

* fix: add \n to instance write

* fix(installer.go): set success to true after succeed for defer func

* refactor

* fix: missing cwd in testutils

* fix: scaleup default runtime nums to 1 when testing

* fix: localruntime appconfig in testing module

* Update internal/core/local_runtime/load_balancing.go

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* fix: more efficiency implement in installer_local.go

* fix: returns after failing in onDebuggingRuntimeDisconnected

* fix: returns after failing in onDebuggingRuntimeDisconnected

* fix: splits tests

* refactor: naming

* refactor: manifest.VersionX

* fix: adapt SetDefault to tests

* fix: enforce use constants in DBType

* fix: generate

* fix: linter

* cleanup tests

* refactor: change  package to

* cleanup: useless codes

* Update internal/cluster/plugin.go

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* cleanup

* refactor: decouple connection_key management from debugging_time

* refactor: confused naming

* feat: recycle resources to adapt to https://github.com/langgenius/dify-plugin-daemon/pull/500

* refactor: confusing redirecting

* fix: support get serverless runtime

* fix: race condition in Launching

* fix: avoid ManifestValidate in first step of debugging handshake

* fix: adding ReleaseAllLocks to finalizers

* wtf: what a beautiful code

* refactor: rename Stream.Async to Stream.Process

* fix: kill process if daed instance was detected

* fix: correctly handle failures

* fix: consistence of difference interfaces

* fix: add stacktrace to panic

* fix: only trigger once  event

* fix: ensure plugin runtime was shutdown

* feat: cleanup install tasks

* fix: add scale logs

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2025-11-18 17:28:02 +08:00

177 lines
5.0 KiB
Go

package tasks
import (
"errors"
"time"
"github.com/langgenius/dify-plugin-daemon/internal/core/plugin_manager"
"github.com/langgenius/dify-plugin-daemon/internal/db"
"github.com/langgenius/dify-plugin-daemon/internal/types/models"
"github.com/langgenius/dify-plugin-daemon/internal/types/models/curd"
"github.com/langgenius/dify-plugin-daemon/pkg/entities/plugin_entities"
"github.com/langgenius/dify-plugin-daemon/pkg/utils/log"
"gorm.io/gorm"
)
type InstallTaskRegistry struct {
Order []string
Tasks map[string]*models.InstallTask
}
func (r *InstallTaskRegistry) IDs() []string {
ids := make([]string, 0, len(r.Order))
for _, tenantID := range r.Order {
if task, ok := r.Tasks[tenantID]; ok {
ids = append(ids, task.ID)
}
}
return ids
}
func (r *InstallTaskRegistry) PrimaryID() string {
if len(r.Order) == 0 {
return ""
}
if task, ok := r.Tasks[r.Order[0]]; ok {
return task.ID
}
return ""
}
func truncateMessage(message string) string {
if len(message) > 1024 {
message = message[:512] + "..." + message[len(message)-512:]
}
return message
}
func SetTaskMessageForOnePlugin(
taskIDs []string,
pluginUniqueIdentifier plugin_entities.PluginUniqueIdentifier,
message string,
) {
// avoid message to be too long, only keep the first 512 and last 512 characters
message = truncateMessage(message)
for _, taskID := range taskIDs {
if err := UpdateTaskStatus(taskID, pluginUniqueIdentifier, func(task *models.InstallTask, plugin *models.InstallTaskPluginStatus) {
plugin.Message = message
}); err != nil {
log.Error("failed to update task message for %s: %v", pluginUniqueIdentifier.String(), err)
}
}
}
func SetTaskStatusForOnePlugin(
taskIDs []string,
pluginUniqueIdentifier plugin_entities.PluginUniqueIdentifier,
status models.InstallTaskStatus,
message string,
) {
// avoid message to be too long, only keep the first 512 and last 512 characters
message = truncateMessage(message)
for _, taskID := range taskIDs {
if err := UpdateTaskStatus(taskID, pluginUniqueIdentifier, func(task *models.InstallTask, plugin *models.InstallTaskPluginStatus) {
previousStatus := plugin.Status
plugin.Status = status
plugin.Message = message
if status == models.InstallTaskStatusSuccess && previousStatus != models.InstallTaskStatusSuccess {
task.CompletedPlugins++
}
if status == models.InstallTaskStatusFailed {
task.Status = models.InstallTaskStatusFailed
if previousStatus == models.InstallTaskStatusSuccess && task.CompletedPlugins > 0 {
task.CompletedPlugins--
}
}
}); err != nil {
log.Error("failed to update task status for %s: %v", pluginUniqueIdentifier.String(), err)
}
}
}
// To update task status more elegant, avoid frequent code like lock and unlock
// this method offers a way to update task status with a modifier function
func UpdateTaskStatus(
taskId string,
pluginUniqueIdentifier plugin_entities.PluginUniqueIdentifier,
modifier func(task *models.InstallTask, plugin *models.InstallTaskPluginStatus),
) error {
return db.WithTransaction(func(tx *gorm.DB) error {
task, err := db.GetOne[models.InstallTask](
db.WithTransactionContext(tx),
db.Equal("id", taskId),
db.WLock(), // write lock, multiple tasks can't update the same task
)
if err == db.ErrDatabaseNotFound {
return nil
}
if err != nil {
return err
}
taskPointer := &task
var pluginStatus *models.InstallTaskPluginStatus
for i := range task.Plugins {
if task.Plugins[i].PluginUniqueIdentifier == pluginUniqueIdentifier {
pluginStatus = &task.Plugins[i]
break
}
}
if pluginStatus == nil {
return nil
}
modifier(taskPointer, pluginStatus)
successes := 0
for _, plugin := range taskPointer.Plugins {
if plugin.Status == models.InstallTaskStatusSuccess {
successes++
}
}
if successes == len(taskPointer.Plugins) {
// update status
taskPointer.Status = models.InstallTaskStatusSuccess
// delete the task after 120 seconds without transaction
time.AfterFunc(120*time.Second, func() {
db.Delete(taskPointer)
})
}
return db.Update(taskPointer, tx)
})
}
func DeleteTask(taskId string) error {
return db.DeleteByCondition(models.InstallTask{
Model: models.Model{
ID: taskId,
},
})
}
func RemovePluginIfNeeded(
manager *plugin_manager.PluginManager,
originalPluginUniqueIdentifier plugin_entities.PluginUniqueIdentifier,
response *curd.UpgradePluginResponse,
) error {
if response.IsOriginalPluginDeleted && response.DeletedPlugin != nil && response.DeletedPlugin.InstallType == plugin_entities.PLUGIN_RUNTIME_TYPE_LOCAL {
// uninstall plugin from local install bucket
if err := manager.RemoveLocalPlugin(originalPluginUniqueIdentifier); err != nil {
return errors.Join(err, errors.New("failed to remove plugin from local install bucket"))
}
// shutdown it gracefully
_, err := manager.ShutdownLocalPluginGracefully(originalPluginUniqueIdentifier)
if err != nil {
return errors.Join(err, errors.New("failed to shutdown plugin gracefully"))
}
}
return nil
}