langgenius/dify-plugin-sdks
1
0
Fork 0
mirror of https://github.com/langgenius/dify-plugin-sdks.git synced 2026-07-22 02:15:22 -04:00
Code Issues 58 Packages Projects Releases 10 Wiki Activity

[PR #125] [MERGED] fix: In debug mode, thread locks block responses and heartbeats, causing TCP to reconnect. #164

New Issue
Closed
opened 2026-02-15 21:16:03 -05:00 by yindo · 0 comments
yindo commented 2026-02-15 21:16:03 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify-plugin-sdks/pull/125
Author: @zengruizhao
Created: 4/29/2025
Status: ✅ Merged
Merged: 4/30/2025
Merged by: @Yeuoly

Base: main ← Head: fix/debug_blocking

📝 Commits (1)

  • 29753e3 fix: remove unnecessary locking in _recv_from_sock method

📊 Changes

1 file changed (+1 additions, -2 deletions)

View changed files

📝 python/dify_plugin/core/server/tcp/request_reader.py (+1 -2)

📄 Description

Summary

In debug mode, thread locks block responses and heartbeats, causing TCP to reconnect.
fixes #98

Screenshots

image

Checklist

Important

Please review the checklist below before submitting your pull request.:

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify-plugin-sdks/pull/125 **Author:** [@zengruizhao](https://github.com/zengruizhao) **Created:** 4/29/2025 **Status:** ✅ Merged **Merged:** 4/30/2025 **Merged by:** [@Yeuoly](https://github.com/Yeuoly) **Base:** `main` ← **Head:** `fix/debug_blocking` --- ### 📝 Commits (1) - [`29753e3`](https://github.com/langgenius/dify-plugin-sdks/commit/29753e3807029b35ca303396368068eacfb19704) fix: remove unnecessary locking in _recv_from_sock method ### 📊 Changes **1 file changed** (+1 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `python/dify_plugin/core/server/tcp/request_reader.py` (+1 -2) </details> ### 📄 Description # Summary In debug mode, thread locks block responses and heartbeats, causing TCP to reconnect. fixes #98 # Screenshots ![image](https://github.com/user-attachments/assets/806ac929-89cb-4fbd-ace3-38f9e230b77a) # Checklist > [!IMPORTANT] > Please review the checklist below before submitting your pull request.: - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 21:16:03 -05:00
yindo closed this issue 2026-02-15 21:16:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
enhancement
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify-plugin-sdks#164
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?