langgenius/dify-plugin-sdks
1
0
Fork 0
mirror of https://github.com/langgenius/dify-plugin-sdks.git synced 2026-07-21 18:05:30 -04:00
Code Issues 58 Packages Projects Releases 10 Wiki Activity

[PR #212] [MERGED] Add comments and unit tests for trigger factory #225

New Issue
Closed
opened 2026-02-15 21:16:19 -05:00 by yindo · 0 comments
yindo commented 2026-02-15 21:16:19 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify-plugin-sdks/pull/212
Author: @Yeuoly
Created: 9/26/2025
Status: ✅ Merged
Merged: 9/26/2025
Merged by: @Yeuoly

Base: feat/trigger ← Head: codex/refactor-github-trigger-implementation

📝 Commits (1)

  • de6614e Add documentation and tests for trigger factory

📊 Changes

5 files changed (+771 additions, -203 deletions)

View changed files

📝 python/dify_plugin/core/plugin_registration.py (+68 -47)
📝 python/dify_plugin/core/trigger_factory.py (+168 -1)
📝 python/dify_plugin/entities/trigger.py (+103 -17)
📝 python/examples/github_trigger/provider/github.py (+170 -138)
➕ python/tests/core/test_trigger_factory.py (+262 -0)

📄 Description

Summary

  • document the trigger factory registry to give contributors more context when registering providers
  • add a dedicated unit test module that verifies provider, constructor, and trigger handling logic

Testing

  • pytest python/tests/core/test_trigger_factory.py

https://chatgpt.com/codex/tasks/task_b_68d6a2c86328832684f70fb76351713b

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify-plugin-sdks/pull/212 **Author:** [@Yeuoly](https://github.com/Yeuoly) **Created:** 9/26/2025 **Status:** ✅ Merged **Merged:** 9/26/2025 **Merged by:** [@Yeuoly](https://github.com/Yeuoly) **Base:** `feat/trigger` ← **Head:** `codex/refactor-github-trigger-implementation` --- ### 📝 Commits (1) - [`de6614e`](https://github.com/langgenius/dify-plugin-sdks/commit/de6614e1b4b3f16b14f862b2938ffbbb0fb430a9) Add documentation and tests for trigger factory ### 📊 Changes **5 files changed** (+771 additions, -203 deletions) <details> <summary>View changed files</summary> 📝 `python/dify_plugin/core/plugin_registration.py` (+68 -47) 📝 `python/dify_plugin/core/trigger_factory.py` (+168 -1) 📝 `python/dify_plugin/entities/trigger.py` (+103 -17) 📝 `python/examples/github_trigger/provider/github.py` (+170 -138) ➕ `python/tests/core/test_trigger_factory.py` (+262 -0) </details> ### 📄 Description ## Summary - document the trigger factory registry to give contributors more context when registering providers - add a dedicated unit test module that verifies provider, constructor, and trigger handling logic ## Testing - pytest python/tests/core/test_trigger_factory.py ------ https://chatgpt.com/codex/tasks/task_b_68d6a2c86328832684f70fb76351713b --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 21:16:19 -05:00
yindo closed this issue 2026-02-15 21:16:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
enhancement
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify-plugin-sdks#225
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?