[PR #216] [MERGED] refactor: tighten typing for lark dispatch helper #230

Closed
opened 2026-02-15 21:16:20 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify-plugin-sdks/pull/216
Author: @Yeuoly
Created: 10/14/2025
Status: Merged
Merged: 10/14/2025
Merged by: @Yeuoly

Base: feat/triggerHead: codex/audit-lark-trigger-implementation


📝 Commits (2)

  • d9a7366 refactor: add generics to lark dispatch helper
  • 9cba1de Merge branch 'feat/trigger' into codex/audit-lark-trigger-implementation

📊 Changes

1 file changed (+66 additions, -16 deletions)

View changed files

📝 python/examples/lark_trigger/events/_shared.py (+66 -16)

📄 Description

Summary

  • replace the Any-based dispatch helper typing with generics and structural protocols so event payloads remain strongly typed
  • add lightweight protocols for runtime subscription and user identity objects to clarify the attributes consumed by shared helpers

Testing

  • ruff check python/examples/lark_trigger/events/_shared.py

https://chatgpt.com/codex/tasks/task_b_68ecf38753ac8326a9878432c081b1d4


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify-plugin-sdks/pull/216 **Author:** [@Yeuoly](https://github.com/Yeuoly) **Created:** 10/14/2025 **Status:** ✅ Merged **Merged:** 10/14/2025 **Merged by:** [@Yeuoly](https://github.com/Yeuoly) **Base:** `feat/trigger` ← **Head:** `codex/audit-lark-trigger-implementation` --- ### 📝 Commits (2) - [`d9a7366`](https://github.com/langgenius/dify-plugin-sdks/commit/d9a73661b4b530f3a9acf3c4a0cf29d4f6207844) refactor: add generics to lark dispatch helper - [`9cba1de`](https://github.com/langgenius/dify-plugin-sdks/commit/9cba1de1d87a8d7b6300656de6b6d16fb78d2acf) Merge branch 'feat/trigger' into codex/audit-lark-trigger-implementation ### 📊 Changes **1 file changed** (+66 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `python/examples/lark_trigger/events/_shared.py` (+66 -16) </details> ### 📄 Description ## Summary - replace the Any-based dispatch helper typing with generics and structural protocols so event payloads remain strongly typed - add lightweight protocols for runtime subscription and user identity objects to clarify the attributes consumed by shared helpers ## Testing - ruff check python/examples/lark_trigger/events/_shared.py ------ https://chatgpt.com/codex/tasks/task_b_68ecf38753ac8326a9878432c081b1d4 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 21:16:20 -05:00
yindo closed this issue 2026-02-15 21:16:20 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify-plugin-sdks#230