langgenius/dify-plugin-sdks
1
0
Fork 0
mirror of https://github.com/langgenius/dify-plugin-sdks.git synced 2026-07-21 18:05:30 -04:00
Code Issues 58 Packages Projects Releases 10 Wiki Activity

[PR #253] fix: add missing icon_small_dark field #263

New Issue
Open
opened 2026-02-15 21:16:29 -05:00 by yindo · 0 comments
yindo commented 2026-02-15 21:16:29 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify-plugin-sdks/pull/253
Author: @hjlarry
Created: 11/28/2025
Status: 🔄 Open

Base: main ← Head: p11

📝 Commits (3)

  • 9c9d791 fix: add missing icon_small_dark field
  • 73903e0 Apply suggestion from @gemini-code-assist[bot]
  • 753aaf3 Apply suggestion from @gemini-code-assist[bot]

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 python/dify_plugin/entities/model/provider.py (+4 -0)

📄 Description

Pull Request Checklist

Thank you for your contribution! Before submitting your PR, please make sure you have completed the following checks:

Compatibility Check

  • I have checked whether this change affects the backward compatibility of the plugin declared in README.md
  • I have checked whether this change affects the forward compatibility of the plugin declared in README.md
  • If this change introduces a breaking change, I have discussed it with the project maintainer and specified the release version in the README.md
  • I have described the compatibility impact and the corresponding version number in the PR description
  • I have checked whether the plugin version is updated in the README.md

Available Checks

  • Code has passed local tests
  • Relevant documentation has been updated (if necessary)

The code here already defines icon_small_dark. We should align this to support the Dify model plugin's dark icon for display.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify-plugin-sdks/pull/253 **Author:** [@hjlarry](https://github.com/hjlarry) **Created:** 11/28/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `p11` --- ### 📝 Commits (3) - [`9c9d791`](https://github.com/langgenius/dify-plugin-sdks/commit/9c9d791f6cc42e71afecc0eee7dc310986d24daa) fix: add missing icon_small_dark field - [`73903e0`](https://github.com/langgenius/dify-plugin-sdks/commit/73903e08f0c2d4e4c3928b982db3213f375f7a00) Apply suggestion from @gemini-code-assist[bot] - [`753aaf3`](https://github.com/langgenius/dify-plugin-sdks/commit/753aaf39abf155f2be3f0be9e2006d224b6c5608) Apply suggestion from @gemini-code-assist[bot] ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `python/dify_plugin/entities/model/provider.py` (+4 -0) </details> ### 📄 Description # Pull Request Checklist Thank you for your contribution! Before submitting your PR, please make sure you have completed the following checks: ## Compatibility Check - [x] I have checked whether this change affects the **backward compatibility** of the plugin declared in `README.md` - [x] I have checked whether this change affects the **forward compatibility** of the plugin declared in `README.md` - [x] If this change introduces a breaking change, I have discussed it with the project maintainer and specified the release version in the `README.md` - [x] I have described the compatibility impact and the corresponding version number in the PR description - [x] I have checked whether the plugin version is updated in the `README.md` ## Available Checks - [x] Code has passed local tests - [x] Relevant documentation has been updated (if necessary) The code [here](https://github.com/langgenius/dify-plugin-sdks/blob/f1d201d9a88054cd70f08aaa12f8c13f8a6af6ed/python/dify_plugin/entities/model/provider.py#L134) already defines `icon_small_dark`. We should align this to support the Dify model plugin's dark icon for display. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 21:16:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
enhancement
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify-plugin-sdks#263
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?