langgenius/dify-plugin-sdks
1
0
Fork 0
mirror of https://github.com/langgenius/dify-plugin-sdks.git synced 2026-07-21 18:05:30 -04:00
Code Issues 58 Packages Projects Releases 10 Wiki Activity

[PR #266] docs: clarify delete_subscription should return success if subscription not found #272

New Issue
Open
opened 2026-02-15 21:16:31 -05:00 by yindo · 0 comments
yindo commented 2026-02-15 21:16:31 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify-plugin-sdks/pull/266
Author: @Mairuis
Created: 12/17/2025
Status: 🔄 Open

Base: main ← Head: docs/clarify-delete-subscription-behavior

📝 Commits (3)

  • 2382210 docs: clarify delete_subscription should return success if subscription not found
  • d404c6a fix: return success for non-existent webhooks in unsubscribe process
  • 91b2679 Update python/dify_plugin/interfaces/trigger/__init__.py

📊 Changes

2 files changed (+7 additions, -4 deletions)

View changed files

📝 python/dify_plugin/interfaces/trigger/__init__.py (+5 -0)
📝 python/examples/github_trigger/provider/github.py (+2 -4)

📄 Description

Summary

  • Add documentation note to delete_subscription method clarifying that it should return success=True when the subscription no longer exists on the external service
  • This ensures idempotent behavior - if the goal is to remove the subscription and it's already gone, that's a success

Test plan

  • Documentation change only, no code changes

🤖 Generated with Claude Code

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify-plugin-sdks/pull/266 **Author:** [@Mairuis](https://github.com/Mairuis) **Created:** 12/17/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `docs/clarify-delete-subscription-behavior` --- ### 📝 Commits (3) - [`2382210`](https://github.com/langgenius/dify-plugin-sdks/commit/2382210867f692d0ff0c88a1fdfb3522cff0526b) docs: clarify delete_subscription should return success if subscription not found - [`d404c6a`](https://github.com/langgenius/dify-plugin-sdks/commit/d404c6a46926d5e0d8dc11e3b26a7caed5f20e1f) fix: return success for non-existent webhooks in unsubscribe process - [`91b2679`](https://github.com/langgenius/dify-plugin-sdks/commit/91b267952572bb8420485ec9957e8082b44f423b) Update python/dify_plugin/interfaces/trigger/__init__.py ### 📊 Changes **2 files changed** (+7 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `python/dify_plugin/interfaces/trigger/__init__.py` (+5 -0) 📝 `python/examples/github_trigger/provider/github.py` (+2 -4) </details> ### 📄 Description ## Summary - Add documentation note to `delete_subscription` method clarifying that it should return `success=True` when the subscription no longer exists on the external service - This ensures idempotent behavior - if the goal is to remove the subscription and it's already gone, that's a success ## Test plan - [x] Documentation change only, no code changes 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 21:16:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
enhancement
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify-plugin-sdks#272
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?