[PR #841] [MERGED] ci: update github actions #1216

Closed
opened 2026-02-22 17:51:25 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify-plugins/pull/841
Author: @lcandy2
Created: 7/2/2025
Status: Merged
Merged: 7/2/2025
Merged by: @crazywoola

Base: mainHead: feat/lcandy/github-actions


📝 Commits (3)

  • 1858d34 fix: update plugin manifest checks to exclude 'dify' as an author
  • 871efd7 feat: enhance plugin validation by adding checks for manifest icon presence and content
  • c859c8e fix: correct asset path in plugin icon validation checks

📊 Changes

1 file changed (+41 additions, -1 deletions)

View changed files

📝 .github/workflows/pre-check-plugin.yaml (+41 -1)

📄 Description

Enhanced Plugin Pre-check Validation

Changes Made:

  1. Author Validation Enhancement

    • Added check to prevent "dify" as plugin author (in addition to existing "langgenius" restriction)
    • Renamed step from "Check Plugin Author" to "Check Plugin Manifest" for better clarity
  2. New Plugin Icon Validation

    • Added comprehensive icon validation step
    • Extracts icon filename from manifest.yaml and sets PLUGIN_ICON_FILENAME environment variable
    • Validates icon file existence in _assets/ directory
    • Prevents use of template placeholder text "DIFY_MARKETPLACE_TEMPLATE_ICON_DO_NOT_USE"
    • Blocks submission of default template icon (ensures custom icons are used)
    • Improved error message with actionable guidance for developers

Purpose:

These changes ensure higher-quality plugin submissions by enforcing proper authorship attribution and requiring custom icons instead of default templates.

Impact:

  • Plugin authors must provide unique author names (not "langgenius" or "dify")
  • Plugin authors must customize their icons before marketplace submission
  • Better error messages guide developers on required changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify-plugins/pull/841 **Author:** [@lcandy2](https://github.com/lcandy2) **Created:** 7/2/2025 **Status:** ✅ Merged **Merged:** 7/2/2025 **Merged by:** [@crazywoola](https://github.com/crazywoola) **Base:** `main` ← **Head:** `feat/lcandy/github-actions` --- ### 📝 Commits (3) - [`1858d34`](https://github.com/langgenius/dify-plugins/commit/1858d3461caecc78ad53ab62197a76e0d0e1988b) fix: update plugin manifest checks to exclude 'dify' as an author - [`871efd7`](https://github.com/langgenius/dify-plugins/commit/871efd7613731fc9457390a1720a6782580a3701) feat: enhance plugin validation by adding checks for manifest icon presence and content - [`c859c8e`](https://github.com/langgenius/dify-plugins/commit/c859c8eec54cd9065031a86eedf62eab5a0f2515) fix: correct asset path in plugin icon validation checks ### 📊 Changes **1 file changed** (+41 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/pre-check-plugin.yaml` (+41 -1) </details> ### 📄 Description ## Enhanced Plugin Pre-check Validation ### Changes Made: 1. **Author Validation Enhancement** - Added check to prevent "dify" as plugin author (in addition to existing "langgenius" restriction) - Renamed step from "Check Plugin Author" to "Check Plugin Manifest" for better clarity 2. **New Plugin Icon Validation** - Added comprehensive icon validation step - Extracts icon filename from manifest.yaml and sets `PLUGIN_ICON_FILENAME` environment variable - Validates icon file existence in `_assets/` directory - Prevents use of template placeholder text "DIFY_MARKETPLACE_TEMPLATE_ICON_DO_NOT_USE" - Blocks submission of default template icon (ensures custom icons are used) - Improved error message with actionable guidance for developers ### Purpose: These changes ensure higher-quality plugin submissions by enforcing proper authorship attribution and requiring custom icons instead of default templates. ### Impact: - Plugin authors must provide unique author names (not "langgenius" or "dify") - Plugin authors must customize their icons before marketplace submission - Better error messages guide developers on required changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 17:51:25 -05:00
yindo closed this issue 2026-02-22 17:51:31 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify-plugins#1216