langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-22 04:25:29 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

chating record displays math expressions incorrectly #1040

New Issue
Closed
opened 2026-02-21 17:29:38 -05:00 by yindo · 5 comments
yindo commented 2026-02-21 17:29:38 -05:00
Owner
Copy Link
Copy Source

Originally created by @bowenliang123 on GitHub (Feb 7, 2024).

Originally assigned to: @crazywoola on GitHub.

Self Checks

Dify version

0.5.4

Cloud or Self Hosted

Self Hosted (Source)

Steps to reproduce

Query: 123+456*789*789

Without tool:
image

With tool: maths

image

✔️ Expected Behavior

Shows the expression correctly in 123+456*789*789.

❌ Actual Behavior

No response

Originally created by @bowenliang123 on GitHub (Feb 7, 2024). Originally assigned to: @crazywoola on GitHub. ### Self Checks - [X] I have searched for existing issues [search for existing issues](https://github.com/langgenius/dify/issues), including closed ones. - [X] I confirm that I am using English to file this report (我已阅读并同意 [Language Policy](https://github.com/langgenius/dify/issues/1542)). ### Dify version 0.5.4 ### Cloud or Self Hosted Self Hosted (Source) ### Steps to reproduce Query: `123+456*789*789` Without tool: ![image](https://github.com/langgenius/dify/assets/1935105/1c01cca9-c27d-4d14-8fa4-dca865164a39) With tool: maths ![image](https://github.com/langgenius/dify/assets/1935105/d7c8f2dc-c0c6-412b-ad3f-11371888ebcf) ### ✔️ Expected Behavior Shows the expression correctly in `123+456*789*789`. ### ❌ Actual Behavior _No response_
yindo added the 🐞 bug label 2026-02-21 17:29:38 -05:00
yindo closed this issue 2026-02-21 17:29:39 -05:00
yindo commented 2026-02-21 17:29:39 -05:00
Author
Owner
Copy Link
Copy Source

@dosubot[bot] commented on GitHub (Feb 7, 2024):

🤖

Hey there @bowenliang123! 😄 Great to see you around again. I'm diving into your issue about the mathematical expression display. Hang tight, I'll get back to you with a full answer shortly!

@dosubot[bot] commented on GitHub (Feb 7, 2024): _🤖_ <!-- Greeting --> Hey there @bowenliang123! 😄 Great to see you around again. I'm diving into your issue about the mathematical expression display. Hang tight, I'll get back to you with a full answer shortly!
yindo commented 2026-02-21 17:29:39 -05:00
Author
Owner
Copy Link
Copy Source

@bowenliang123 commented on GitHub (Feb 7, 2024):

cc @crazywoola

@bowenliang123 commented on GitHub (Feb 7, 2024): cc @crazywoola
yindo commented 2026-02-21 17:29:39 -05:00
Author
Owner
Copy Link
Copy Source

@dosubot[bot] commented on GitHub (Feb 7, 2024):

🤖

Based on the information you've provided, it seems like the Dify tool is correctly evaluating the mathematical expression 123+456*789*789 according to the standard order of operations (PEMDAS/BODMAS). This means that multiplication and division are performed before addition and subtraction. So, in the expression 123+456*789*789, the multiplication operations 456*789*789 are performed first, and then the result is added to 123.

The EvaluateExpressionTool class in the Dify tool uses the numexpr library to evaluate the expression and then returns a string message with the result. You can find the relevant code in the api/core/tools/provider/builtin/maths/tools/eval_expression.py file.

If you want the addition operation 123+456 to be performed first, you should modify the expression to (123+456)*789*789.

If the tool is not following this order of operations, then it's a bug in the numexpr library or in the way the tool is using it. If you believe this is the case, could you please provide more details about the incorrect output you're seeing? This will help us better understand the issue and find a solution.

Sources

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

@dosubot[bot] commented on GitHub (Feb 7, 2024): _🤖_ <!-- Answer --> Based on the information you've provided, it seems like the Dify tool is correctly evaluating the mathematical expression `123+456*789*789` according to the standard order of operations (PEMDAS/BODMAS). This means that multiplication and division are performed before addition and subtraction. So, in the expression `123+456*789*789`, the multiplication operations `456*789*789` are performed first, and then the result is added to `123`. The `EvaluateExpressionTool` class in the Dify tool uses the `numexpr` library to evaluate the expression and then returns a string message with the result. You can find the relevant code in the [api/core/tools/provider/builtin/maths/tools/eval_expression.py](https://github.com/langgenius/dify/blob/main/api/core/tools/provider/builtin/maths/tools/eval_expression.py) file. If you want the addition operation `123+456` to be performed first, you should modify the expression to `(123+456)*789*789`. If the tool is not following this order of operations, then it's a bug in the `numexpr` library or in the way the tool is using it. If you believe this is the case, could you please provide more details about the incorrect output you're seeing? This will help us better understand the issue and find a solution. ## Sources - [api/core/tools/provider/builtin/maths/tools/eval_expression.py](https://github.com/langgenius/dify/blob/main/api/core/tools/provider/builtin/maths/tools/eval_expression.py) --- This response is meant to be useful and save you time. It is **not meant to be a precise solution**, but rather a starting point for your own research. Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant. If you want to continue the conversation, start your reply with @dosu-bot.
yindo commented 2026-02-21 17:29:39 -05:00
Author
Owner
Copy Link
Copy Source

@takatost commented on GitHub (Feb 7, 2024):

This seems to be parsed as Markdown syntax. Maybe we can add a sentence in the instructions, saying that mathematical expressions should be represented using inline code block.

@takatost commented on GitHub (Feb 7, 2024): This seems to be parsed as Markdown syntax. Maybe we can add a sentence in the instructions, saying that mathematical expressions should be represented using `inline code block`.
yindo commented 2026-02-21 17:29:39 -05:00
Author
Owner
Copy Link
Copy Source

@dosubot[bot] commented on GitHub (Mar 29, 2024):

Hi, @bowenliang123,

I'm helping the team manage their backlog and am marking this issue as stale. From what I understand, you reported an issue with the chat record in Dify version 0.5.4 displaying math expressions incorrectly. I provided an explanation of the order of operations and suggested modifying the expression to ensure the desired calculation order, and takatost suggested adding a sentence in the instructions to represent mathematical expressions using inline code blocks. The issue has been resolved with my explanation and the implementation of takatost's suggestion.

Could you please confirm if this issue is still relevant to the latest version of the repository? If it is, please let the team know by commenting on the issue. Otherwise, feel free to close the issue yourself, or it will be automatically closed in 7 days. Thank you!

@dosubot[bot] commented on GitHub (Mar 29, 2024): <!-- Answer --> Hi, @bowenliang123, I'm helping the team manage their backlog and am marking this issue as stale. From what I understand, you reported an issue with the chat record in Dify version 0.5.4 displaying math expressions incorrectly. I provided an explanation of the order of operations and suggested modifying the expression to ensure the desired calculation order, and takatost suggested adding a sentence in the instructions to represent mathematical expressions using inline code blocks. The issue has been resolved with my explanation and the implementation of takatost's suggestion. Could you please confirm if this issue is still relevant to the latest version of the repository? If it is, please let the team know by commenting on the issue. Otherwise, feel free to close the issue yourself, or it will be automatically closed in 7 days. Thank you!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label 🐞 bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#1040
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?