langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

Parent Child should not be visible in Economical mode #11988

New Issue
Closed
opened 2026-02-21 19:05:08 -05:00 by yindo · 3 comments
yindo commented 2026-02-21 19:05:08 -05:00
Owner
Copy Link
Copy Source

Originally created by @DavideDelbianco on GitHub (Mar 22, 2025).

Originally assigned to: @WTW0313 on GitHub.

Self Checks

  • This is only for bug report, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report (我已阅读并同意 Language Policy).
  • [FOR CHINESE USERS] 请务必使用英文提交 Issue，否则会被关闭。谢谢！:)
  • Please do not modify this template :) and fill in all the required fields.

Dify version

1.1.2

Cloud or Self Hosted

Cloud

Steps to reproduce

Create a Knowledge without having an embedding model setup

✔️ Expected Behavior

Should not be possible to select a High Quality (embed model required) indexing method from the Economical tab
Allowing to select "Parent Child" will make it impossible to switch back to Economical mode and the UI will ask for an embedding model, requiring page refresh.

Image

❌ Actual Behavior

High Quality indexing method is visible in Economical tab

Originally created by @DavideDelbianco on GitHub (Mar 22, 2025). Originally assigned to: @WTW0313 on GitHub. ### Self Checks - [x] This is only for bug report, if you would like to ask a question, please head to [Discussions](https://github.com/langgenius/dify/discussions/categories/general). - [x] I have searched for existing issues [search for existing issues](https://github.com/langgenius/dify/issues), including closed ones. - [x] I confirm that I am using English to submit this report (我已阅读并同意 [Language Policy](https://github.com/langgenius/dify/issues/1542)). - [x] [FOR CHINESE USERS] 请务必使用英文提交 Issue，否则会被关闭。谢谢！:) - [x] Please do not modify this template :) and fill in all the required fields. ### Dify version 1.1.2 ### Cloud or Self Hosted Cloud ### Steps to reproduce Create a Knowledge without having an embedding model setup ### ✔️ Expected Behavior Should not be possible to select a High Quality (embed model required) indexing method from the Economical tab Allowing to select "Parent Child" will make it impossible to switch back to Economical mode and the UI will ask for an embedding model, requiring page refresh. ![Image](https://github.com/user-attachments/assets/046e6729-036c-47d2-8025-d8e9eaedf37a) ### ❌ Actual Behavior High Quality indexing method is visible in Economical tab
yindo added the 🐞 bugcloud labels 2026-02-21 19:05:08 -05:00
yindo closed this issue 2026-02-21 19:05:08 -05:00
yindo commented 2026-02-21 19:05:09 -05:00
Author
Owner
Copy Link
Copy Source

@dosubot[bot] commented on GitHub (Mar 22, 2025):

The issue you're encountering is likely due to the IndexMethodRadio component not being properly disabled when the embedding model is not set up. The "High Quality" indexing method should be disabled if the embedding_available flag is not set to true. This flag is used to determine whether the "High Quality" option should be selectable. If it's not correctly reflecting the setup status of the embedding model, the option might be incorrectly enabled [1][2].

To continue talking to Dosu, mention @dosu.

Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Bug Report | Other

@dosubot[bot] commented on GitHub (Mar 22, 2025): <!-- Answer --> The issue you're encountering is likely due to the `IndexMethodRadio` component not being properly disabled when the embedding model is not set up. The "High Quality" indexing method should be disabled if the `embedding_available` flag is not set to true. This flag is used to determine whether the "High Quality" option should be selectable. If it's not correctly reflecting the setup status of the embedding model, the option might be incorrectly enabled <sup>[[1]](https://github.com/langgenius/dify/blob/main/web/app/components/datasets/settings/form/index.tsx)</sup><sup>[[2]](https://github.com/langgenius/dify/blob/main/web/i18n/it-IT/dataset-settings.ts)</sup>. <!-- Dosu Comment Footer --> *To continue talking to [Dosu](https://dosu.dev), mention @dosu.* --- <sup>Help Dosu learn! Give it feedback: [Great Response](https://app.dosu.dev/response-feedback/754e6008-d7e7-4fd3-8316-0a5c6aba4faa?feedback_type=great_response) | [Irrelevant Answer](https://app.dosu.dev/response-feedback/754e6008-d7e7-4fd3-8316-0a5c6aba4faa?feedback_type=irrelevant_answer) | [Incorrect Sources](https://app.dosu.dev/response-feedback/754e6008-d7e7-4fd3-8316-0a5c6aba4faa?feedback_type=incorrect_sources) | [Too Verbose](https://app.dosu.dev/response-feedback/754e6008-d7e7-4fd3-8316-0a5c6aba4faa?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/754e6008-d7e7-4fd3-8316-0a5c6aba4faa?feedback_type=hallucination) | [Bug Report](https://app.dosu.dev/response-feedback/754e6008-d7e7-4fd3-8316-0a5c6aba4faa?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/754e6008-d7e7-4fd3-8316-0a5c6aba4faa?feedback_type=other)</sup>
yindo commented 2026-02-21 19:05:09 -05:00
Author
Owner
Copy Link
Copy Source

@WTW0313 commented on GitHub (Mar 24, 2025):

Hello, @DavideDelbianco. Thank you for sharing your proposal with us. The main goal of this design is to encourage users to enjoy a better experience by using the embedding model. So the High Quality option will be visible regardless of whether the user has configured the embedding model or not. And that's why there is a RECOMMEND badge on the High Quality option.

@WTW0313 commented on GitHub (Mar 24, 2025): Hello, @DavideDelbianco. Thank you for sharing your proposal with us. The main goal of this design is to encourage users to enjoy a better experience by using the embedding model. So the `High Quality` option will be visible regardless of whether the user has configured the embedding model or not. And that's why there is a `RECOMMEND` badge on the `High Quality` option.
yindo commented 2026-02-21 19:05:09 -05:00
Author
Owner
Copy Link
Copy Source

@DavideDelbianco commented on GitHub (Mar 25, 2025):

@WTW0313 it's ok to encourage users to use embedding models, but it is still bad UX if the user is stuck in a dead-end
I have rephrased this issue to accomodate the visibility and discoverability of embedding-models-based indexing methods, without forcing the user in a dead end #16733

@DavideDelbianco commented on GitHub (Mar 25, 2025): @WTW0313 it's ok to encourage users to use embedding models, but it is still bad UX if the user is stuck in a dead-end I have rephrased this issue to accomodate the visibility and discoverability of embedding-models-based indexing methods, without forcing the user in a dead end #16733
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label cloud 🐞 bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#11988
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?