langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 03:55:25 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[Chore/Refactor] adapt async / await #16004

New Issue
Open
opened 2026-02-21 19:24:18 -05:00 by yindo · 6 comments
yindo commented 2026-02-21 19:24:18 -05:00
Owner
Copy Link
Copy Source

Originally created by @asukaminato0721 on GitHub (Aug 8, 2025).

Self Checks

  • I have read the Contributing Guide and Language Policy.
  • This is only for refactoring, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：）
  • Please do not modify this template :) and fill in all the required fields.

Description

Now this project uses gevent, but mainstream uses async / await.

it requires several steps, so this will involve several pr.

Motivation

better maintainness.

and better third lib.

Additional Context

No response

Originally created by @asukaminato0721 on GitHub (Aug 8, 2025). ### Self Checks - [x] I have read the [Contributing Guide](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) and [Language Policy](https://github.com/langgenius/dify/issues/1542). - [x] This is only for refactoring, if you would like to ask a question, please head to [Discussions](https://github.com/langgenius/dify/discussions/categories/general). - [x] I have searched for existing issues [search for existing issues](https://github.com/langgenius/dify/issues), including closed ones. - [x] I confirm that I am using English to submit this report, otherwise it will be closed. - [x] 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：） - [x] Please do not modify this template :) and fill in all the required fields. ### Description Now this project uses gevent, but mainstream uses async / await. it requires several steps, so this will involve several pr. - [x] #24006 - [ ] flask -> fastapi or https://github.com/pallets/quart ? which seems maybe easier? - [ ] ~~sqlachemy -> it's async engine~~ ... ### Motivation better maintainness. and better third lib. ### Additional Context _No response_
yindo commented 2026-02-21 19:24:18 -05:00
Author
Owner
Copy Link
Copy Source

@EchterTimo commented on GitHub (Aug 13, 2025):

+1

@EchterTimo commented on GitHub (Aug 13, 2025): +1
yindo commented 2026-02-21 19:24:18 -05:00
Author
Owner
Copy Link
Copy Source

@asukaminato0721 commented on GitHub (Aug 22, 2025):

https://palletsprojects.com/ oh, quart is kind of official flask async version, but first use flask async version...

@asukaminato0721 commented on GitHub (Aug 22, 2025): https://palletsprojects.com/ oh, quart is kind of official flask async version, but first use flask async version...
yindo commented 2026-02-21 19:24:18 -05:00
Author
Owner
Copy Link
Copy Source

@yihong0618 commented on GitHub (Aug 22, 2025):

flask -> fastapi or https://github.com/pallets/quart ? which seems maybe easier?

its hard all use flask include the database mirgrate

just using flask async is better

@yihong0618 commented on GitHub (Aug 22, 2025): flask -> fastapi or https://github.com/pallets/quart ? which seems maybe easier? its hard all use flask include the database mirgrate just using flask async is better
yindo commented 2026-02-21 19:24:18 -05:00
Author
Owner
Copy Link
Copy Source

@dosubot[bot] commented on GitHub (Sep 22, 2025):

Hi, @asukaminato0721. I'm Dosu, and I'm helping the Dify team manage their backlog and am marking this issue as stale.

Issue Summary

  • You proposed refactoring the project to replace gevent with async/await for better maintainability and third-party library support.
  • The plan involves a multi-step migration: moving from Flask to FastAPI or Quart and updating SQLAlchemy to async.
  • Discussion includes whether to switch to FastAPI or Quart, with suggestions that using Flask's async support might be simpler.
  • Comments highlight the complexity of migrating both the database and framework simultaneously.
  • The proposal has received some positive feedback, including a +1 from EchterTimo.

Next Steps

  • Please let me know if this issue is still relevant to the latest version of Dify by commenting here to keep the discussion open.
  • Otherwise, I will automatically close this issue in 15 days.

Thank you for your understanding and contribution!

@dosubot[bot] commented on GitHub (Sep 22, 2025): Hi, @asukaminato0721. I'm [Dosu](https://dosu.dev), and I'm helping the Dify team manage their backlog and am marking this issue as stale. **Issue Summary** - You proposed refactoring the project to replace gevent with async/await for better maintainability and third-party library support. - The plan involves a multi-step migration: moving from Flask to FastAPI or Quart and updating SQLAlchemy to async. - Discussion includes whether to switch to FastAPI or Quart, with suggestions that using Flask's async support might be simpler. - Comments highlight the complexity of migrating both the database and framework simultaneously. - The proposal has received some positive feedback, including a +1 from EchterTimo. **Next Steps** - Please let me know if this issue is still relevant to the latest version of Dify by commenting here to keep the discussion open. - Otherwise, I will automatically close this issue in 15 days. Thank you for your understanding and contribution!
yindo commented 2026-02-21 19:24:18 -05:00
Author
Owner
Copy Link
Copy Source

@EchterTimo commented on GitHub (Jan 31, 2026):

So how are we going to continue with this issue?

@EchterTimo commented on GitHub (Jan 31, 2026): So how are we going to continue with this issue?
yindo commented 2026-02-21 19:24:18 -05:00
Author
Owner
Copy Link
Copy Source

@asukaminato0721 commented on GitHub (Jan 31, 2026):

So how are we going to continue with this issue?

https://github.com/langgenius/dify/issues/30269

@asukaminato0721 commented on GitHub (Jan 31, 2026): > So how are we going to continue with this issue? https://github.com/langgenius/dify/issues/30269
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#16004
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?