langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-08-24 22:11:36 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[Chore/Refactor] SimpleSelect chevron icon state desync and missing notClearable prop #16110

New Issue
Closed
opened 2026-02-21 19:24:41 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 19:24:41 -05:00
Owner
Copy Link
Copy Source

Originally created by @lyzno1 on GitHub (Aug 13, 2025).

Self Checks

  • I have read the Contributing Guide and Language Policy.
  • This is only for refactoring, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：）
  • Please do not modify this template :) and fill in all the required fields.

Description

The SimpleSelect component has two issues:

  1. Chevron icon state desync: When users click outside to close the dropdown, the chevron icon (v/^) doesn't update correctly - it remains as up arrow (^) even though the dropdown is closed. The icon only updates when clicking the component again. This happens because the component's local state doesn't sync with Headless UI's internal state changes.

  2. Missing notClearable in monitoring interface: The model selection dropdown in the monitoring dashboard allows accidental clearing of selected items.

Motivation

Solution

  • Fix chevron state by using Headless UI's render prop pattern to access actual open state
  • Add notClearable prop to monitoring model selector to prevent accidental deselection

Additional Context

No response

Originally created by @lyzno1 on GitHub (Aug 13, 2025). ### Self Checks - [x] I have read the [Contributing Guide](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) and [Language Policy](https://github.com/langgenius/dify/issues/1542). - [x] This is only for refactoring, if you would like to ask a question, please head to [Discussions](https://github.com/langgenius/dify/discussions/categories/general). - [x] I have searched for existing issues [search for existing issues](https://github.com/langgenius/dify/issues), including closed ones. - [x] I confirm that I am using English to submit this report, otherwise it will be closed. - [x] 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：） - [x] Please do not modify this template :) and fill in all the required fields. ### Description The SimpleSelect component has two issues: 1. **Chevron icon state desync**: When users click outside to close the dropdown, the chevron icon (v/^) doesn't update correctly - it remains as up arrow (^) even though the dropdown is closed. The icon only updates when clicking the component again. This happens because the component's local state doesn't sync with Headless UI's internal state changes. 2. **Missing notClearable in monitoring interface**: The model selection dropdown in the monitoring dashboard allows accidental clearing of selected items. ### Motivation ## Solution - Fix chevron state by using Headless UI's render prop pattern to access actual open state - Add notClearable prop to monitoring model selector to prevent accidental deselection ### Additional Context _No response_
yindo added the 💪 enhancement label 2026-02-21 19:24:41 -05:00
yindo closed this issue 2026-02-21 19:24:41 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label 💪 enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#16110
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?