langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[Chore] redundant acceptedKeys check in completion-params.ts #16130

New Issue
Closed
opened 2026-02-21 19:24:45 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 19:24:45 -05:00
Owner
Copy Link
Copy Source

Originally created by @hyongtao-code on GitHub (Aug 13, 2025).

Currently, mergeValidCompletionParams maintains both acceptedKeys (a Set of rule names) and ruleMap (a mapping from rule name to rule object) to check whether a key is supported. Both data structures are built from the same rules array, so their existence checks are equivalent. This results in duplicate maintenance and redundant logic.

https://github.com/langgenius/dify/blob/main/web/utils/completion-params.ts#L20-L30

Originally created by @hyongtao-code on GitHub (Aug 13, 2025). Currently, `mergeValidCompletionParams` maintains both `acceptedKeys` (a Set of rule names) and `ruleMap` (a mapping from rule name to rule object) to check whether a key is supported. Both data structures are built from the same rules array, so their existence checks are equivalent. This results in duplicate maintenance and redundant logic. https://github.com/langgenius/dify/blob/main/web/utils/completion-params.ts#L20-L30
yindo closed this issue 2026-02-21 19:24:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#16130
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?