langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[Chore/Refactor] x: T = None to x: Optional[T] = None #16222

New Issue
Closed
opened 2026-02-21 19:25:09 -05:00 by yindo · 3 comments
yindo commented 2026-02-21 19:25:09 -05:00
Owner
Copy Link
Copy Source

Originally created by @asukaminato0721 on GitHub (Aug 17, 2025).

Originally assigned to: @Gnomeek on GitHub.

Self Checks

  • I have read the Contributing Guide and Language Policy.
  • This is only for refactoring, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：）
  • Please do not modify this template :) and fill in all the required fields.

Description

api/tests/integration_tests/vdb/__mock/baiduvectordb.py and maybe other places.

adapter: HTTPAdapter = None,

better:

adapter: Optional[HTTPAdapter] = None,

Motivation

make type checker happy.

Additional Context

No response

Originally created by @asukaminato0721 on GitHub (Aug 17, 2025). Originally assigned to: @Gnomeek on GitHub. ### Self Checks - [x] I have read the [Contributing Guide](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) and [Language Policy](https://github.com/langgenius/dify/issues/1542). - [x] This is only for refactoring, if you would like to ask a question, please head to [Discussions](https://github.com/langgenius/dify/discussions/categories/general). - [x] I have searched for existing issues [search for existing issues](https://github.com/langgenius/dify/issues), including closed ones. - [x] I confirm that I am using English to submit this report, otherwise it will be closed. - [x] 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：） - [x] Please do not modify this template :) and fill in all the required fields. ### Description api/tests/integration_tests/vdb/__mock/baiduvectordb.py and maybe other places. ```py adapter: HTTPAdapter = None, ``` better: ```py adapter: Optional[HTTPAdapter] = None, ``` ### Motivation make type checker happy. ### Additional Context _No response_
yindo added the good first issue label 2026-02-21 19:25:09 -05:00
yindo closed this issue 2026-02-21 19:25:10 -05:00
yindo commented 2026-02-21 19:25:10 -05:00
Author
Owner
Copy Link
Copy Source

@asukaminato0721 commented on GitHub (Aug 17, 2025):

another pattern by ty

error[invalid-argument-type]: Argument to function `validate_url_with_path` is incorrect
  --> tests/unit_tests/core/ops/test_utils.py:93:41
   |
91 |     def test_none_url_returns_default(self):
92 |         """Test None URL returns default"""
93 |         result = validate_url_with_path(None, "https://default.com/")
   |                                         ^^^^ Expected `str`, found `None`
94 |         assert result == "https://default.com/"
   |
info: Function defined here
   --> core/ops/utils.py:105:5
    |
105 | def validate_url_with_path(url: str, default_url: str, required_suffix: str | None = None) -> str:
    |     ^^^^^^^^^^^^^^^^^^^^^^ -------- Parameter declared here
106 |     """
107 |     Validate URL that may include path components
    |
info: rule `invalid-argument-type` is enabled by default
@asukaminato0721 commented on GitHub (Aug 17, 2025): another pattern by ty ```py error[invalid-argument-type]: Argument to function `validate_url_with_path` is incorrect --> tests/unit_tests/core/ops/test_utils.py:93:41 | 91 | def test_none_url_returns_default(self): 92 | """Test None URL returns default""" 93 | result = validate_url_with_path(None, "https://default.com/") | ^^^^ Expected `str`, found `None` 94 | assert result == "https://default.com/" | info: Function defined here --> core/ops/utils.py:105:5 | 105 | def validate_url_with_path(url: str, default_url: str, required_suffix: str | None = None) -> str: | ^^^^^^^^^^^^^^^^^^^^^^ -------- Parameter declared here 106 | """ 107 | Validate URL that may include path components | info: rule `invalid-argument-type` is enabled by default ```
yindo commented 2026-02-21 19:25:10 -05:00
Author
Owner
Copy Link
Copy Source

@Gnomeek commented on GitHub (Aug 19, 2025):

I can grab this ticket if it's still available

@Gnomeek commented on GitHub (Aug 19, 2025): I can grab this ticket if it's still available
yindo commented 2026-02-21 19:25:10 -05:00
Author
Owner
Copy Link
Copy Source

@Gnomeek commented on GitHub (Aug 20, 2025):

ref: #24217

@Gnomeek commented on GitHub (Aug 20, 2025): ref: #24217
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label good first issue
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#16222
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?