langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-20 19:50:06 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[Chore/Refactor] db.session.xxx -> with Session as session #16246

New Issue
Open
opened 2026-02-21 19:25:17 -05:00 by yindo · 6 comments
yindo commented 2026-02-21 19:25:17 -05:00
Owner
Copy Link
Copy Source

Originally created by @asukaminato0721 on GitHub (Aug 18, 2025).

Self Checks

  • I have read the Contributing Guide and Language Policy.
  • This is only for refactoring, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：）
  • Please do not modify this template :) and fill in all the required fields.

Description

db.session.commit() is Flask-SQLAlchemy

with Session(...) is Pure SQLAlchemy

Image

Motivation

for migration.

Additional Context

https://docs.sqlalchemy.org/en/20/orm/session_basics.html#framing-out-a-begin-commit-rollback-block

part of #23647

need https://github.com/facebook/pyrefly/issues/954

one example: #24135

Originally created by @asukaminato0721 on GitHub (Aug 18, 2025). ### Self Checks - [x] I have read the [Contributing Guide](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) and [Language Policy](https://github.com/langgenius/dify/issues/1542). - [x] This is only for refactoring, if you would like to ask a question, please head to [Discussions](https://github.com/langgenius/dify/discussions/categories/general). - [x] I have searched for existing issues [search for existing issues](https://github.com/langgenius/dify/issues), including closed ones. - [x] I confirm that I am using English to submit this report, otherwise it will be closed. - [x] 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：） - [x] Please do not modify this template :) and fill in all the required fields. ### Description db.session.commit() is Flask-SQLAlchemy with Session(...) is Pure SQLAlchemy <img width="519" height="253" alt="Image" src="https://github.com/user-attachments/assets/cfaa3fb9-92e1-406c-bcd9-e54d848b42be" /> ### Motivation for migration. ### Additional Context https://docs.sqlalchemy.org/en/20/orm/session_basics.html#framing-out-a-begin-commit-rollback-block part of #23647 need https://github.com/facebook/pyrefly/issues/954 one example: #24135
yindo added the good first issue label 2026-02-21 19:25:17 -05:00
yindo commented 2026-02-21 19:25:17 -05:00
Author
Owner
Copy Link
Copy Source

@liugddx commented on GitHub (Aug 18, 2025):

I will try

@liugddx commented on GitHub (Aug 18, 2025): I will try
yindo commented 2026-02-21 19:25:17 -05:00
Author
Owner
Copy Link
Copy Source

@laipz8200 commented on GitHub (Aug 18, 2025):

It seems this hasn't changed anything?

@laipz8200 commented on GitHub (Aug 18, 2025): It seems this hasn't changed anything?
yindo commented 2026-02-21 19:25:17 -05:00
Author
Owner
Copy Link
Copy Source

@asukaminato0721 commented on GitHub (Aug 18, 2025):

It seems this hasn't changed anything?

prepare for #24138

@asukaminato0721 commented on GitHub (Aug 18, 2025): > It seems this hasn't changed anything? prepare for #24138
yindo commented 2026-02-21 19:25:17 -05:00
Author
Owner
Copy Link
Copy Source

@ruanimal commented on GitHub (Sep 4, 2025):

why use Pure SQLAlchemy ？

@ruanimal commented on GitHub (Sep 4, 2025): why use Pure SQLAlchemy ？
yindo commented 2026-02-21 19:25:17 -05:00
Author
Owner
Copy Link
Copy Source

@asukaminato0721 commented on GitHub (Sep 23, 2025):

why use Pure SQLAlchemy ？

https://github.com/langgenius/dify/pull/10921#issuecomment-2490099306

@asukaminato0721 commented on GitHub (Sep 23, 2025): > why use Pure SQLAlchemy ？ https://github.com/langgenius/dify/pull/10921#issuecomment-2490099306
yindo commented 2026-02-21 19:25:17 -05:00
Author
Owner
Copy Link
Copy Source

@asukaminato0721 commented on GitHub (Jan 21, 2026):

still some remaining places.

@asukaminato0721 commented on GitHub (Jan 21, 2026): still some remaining places.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label good first issue
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#16246
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?