langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 03:55:25 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[Chore/Refactor] use sqlalchemy engine #16253

New Issue
Open
opened 2026-02-21 19:25:19 -05:00 by yindo · 2 comments
yindo commented 2026-02-21 19:25:19 -05:00
Owner
Copy Link
Copy Source

Originally created by @asukaminato0721 on GitHub (Aug 18, 2025).

Originally assigned to: @asukaminato0721 on GitHub.

Self Checks

  • I have read the Contributing Guide and Language Policy.
  • This is only for refactoring, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：）
  • Please do not modify this template :) and fill in all the required fields.

Description

continue of #24115

after it, all will be

with Session(db.engine) as session:
    ...

then only db is from

from flask_sqlalchemy import SQLAlchemy

db = SQLAlchemy(metadata=metadata)

then can use engine from SQLAlchemy itself.

Motivation

One more step to remove flask_sqlalchemy

Additional Context

part of #23647

Originally created by @asukaminato0721 on GitHub (Aug 18, 2025). Originally assigned to: @asukaminato0721 on GitHub. ### Self Checks - [x] I have read the [Contributing Guide](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) and [Language Policy](https://github.com/langgenius/dify/issues/1542). - [x] This is only for refactoring, if you would like to ask a question, please head to [Discussions](https://github.com/langgenius/dify/discussions/categories/general). - [x] I have searched for existing issues [search for existing issues](https://github.com/langgenius/dify/issues), including closed ones. - [x] I confirm that I am using English to submit this report, otherwise it will be closed. - [x] 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：） - [x] Please do not modify this template :) and fill in all the required fields. ### Description continue of #24115 after it, all will be ```py with Session(db.engine) as session: ... ``` then only db is from ```py from flask_sqlalchemy import SQLAlchemy db = SQLAlchemy(metadata=metadata) ``` then can use engine from SQLAlchemy itself. ### Motivation One more step to remove flask_sqlalchemy ### Additional Context part of #23647
yindo commented 2026-02-21 19:25:19 -05:00
Author
Owner
Copy Link
Copy Source

@dosubot[bot] commented on GitHub (Sep 20, 2025):

Hi, @asukaminato0721. I'm Dosu, and I'm helping the Dify team manage their backlog and am marking this issue as stale.

Issue Summary

  • You proposed refactoring to use SQLAlchemy's engine directly with Session(db.engine) to simplify the db initialization.
  • This aims to reduce dependency on Flask-SQLAlchemy, building on previous improvements from issues #24115 and #23647.
  • There has been no further activity or comments on this suggestion since it was opened.

Next Steps

  • Please let me know if this issue is still relevant with the latest version of Dify by commenting here.
  • If I do not hear back within 15 days, I will automatically close this issue.

Thank you for your understanding and contribution!

@dosubot[bot] commented on GitHub (Sep 20, 2025): Hi, @asukaminato0721. I'm [Dosu](https://dosu.dev), and I'm helping the Dify team manage their backlog and am marking this issue as stale. **Issue Summary** - You proposed refactoring to use SQLAlchemy's engine directly with `Session(db.engine)` to simplify the `db` initialization. - This aims to reduce dependency on Flask-SQLAlchemy, building on previous improvements from issues #24115 and #23647. - There has been no further activity or comments on this suggestion since it was opened. **Next Steps** - Please let me know if this issue is still relevant with the latest version of Dify by commenting here. - If I do not hear back within 15 days, I will automatically close this issue. Thank you for your understanding and contribution!
yindo commented 2026-02-21 19:25:19 -05:00
Author
Owner
Copy Link
Copy Source

@asukaminato0721 commented on GitHub (Feb 5, 2026):

@dosu what is current progress

@asukaminato0721 commented on GitHub (Feb 5, 2026): @dosu what is current progress
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#16253
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?