langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

Fix missing database commit in provider update handler #16362

New Issue
Closed
opened 2026-02-21 19:25:49 -05:00 by yindo · 1 comment
yindo commented 2026-02-21 19:25:49 -05:00
Owner
Copy Link
Copy Source

Originally created by @laipz8200 on GitHub (Aug 22, 2025).

Originally assigned to: @laipz8200 on GitHub.

Self Checks

  • I have read the Contributing Guide and Language Policy.
  • This is only for bug report, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：）
  • Please do not modify this template :) and fill in all the required fields.

Dify version

Latest development version

Cloud or Self Hosted

Self Hosted (Source)

Steps to reproduce

  1. Trigger a message creation event that causes provider quota updates
  2. Observe that the database transaction updates are prepared but not committed
  3. Check the database and notice that provider quota deductions are not persisted

✔️ Expected Behavior

When provider quotas are updated after message creation, the changes should be committed to the database to ensure accurate tracking of usage and remaining quotas.

❌ Actual Behavior

The provider update handler prepares database updates but doesn't commit them to the database. The updates are lost when the session ends, causing incorrect quota tracking and potential overuse of provider limits.

Originally created by @laipz8200 on GitHub (Aug 22, 2025). Originally assigned to: @laipz8200 on GitHub. ## Self Checks - [x] I have read the [Contributing Guide](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) and [Language Policy](https://github.com/langgenius/dify/issues/1542). - [x] This is only for bug report, if you would like to ask a question, please head to [Discussions](https://github.com/langgenius/dify/discussions/categories/general). - [x] I have searched for existing issues [search for existing issues](https://github.com/langgenius/dify/issues), including closed ones. - [x] I confirm that I am using English to submit this report, otherwise it will be closed. - [x] 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：） - [x] Please do not modify this template :) and fill in all the required fields. ## Dify version Latest development version ## Cloud or Self Hosted Self Hosted (Source) ## Steps to reproduce 1. Trigger a message creation event that causes provider quota updates 2. Observe that the database transaction updates are prepared but not committed 3. Check the database and notice that provider quota deductions are not persisted ## ✔️ Expected Behavior When provider quotas are updated after message creation, the changes should be committed to the database to ensure accurate tracking of usage and remaining quotas. ## ❌ Actual Behavior The provider update handler prepares database updates but doesn't commit them to the database. The updates are lost when the session ends, causing incorrect quota tracking and potential overuse of provider limits.
yindo added the 🐞 bug label 2026-02-21 19:25:49 -05:00
yindo closed this issue 2026-02-21 19:25:49 -05:00
yindo commented 2026-02-21 19:25:49 -05:00
Author
Owner
Copy Link
Copy Source

@dosubot[bot] commented on GitHub (Aug 22, 2025):

The provider update handler for quota deductions is implemented in api/events/event_handlers/update_provider_when_message_created.py. The function _execute_provider_updates uses a SQLAlchemy Session context manager (with Session(db.engine) as session:) to execute updates, but does not explicitly call session.commit(). While the context manager should commit on exit if no exceptions occur, missing or unreliable commits can cause quota updates to not persist as you've observed.

To fix this, add an explicit session.commit() at the end of the update loop in _execute_provider_updates, after all updates are executed. This matches best practices used elsewhere in the codebase for provider updates and ensures changes are reliably saved to the database. For example:

with Session(db.engine) as session:
    # ... perform updates ...
    session.commit()

This change will ensure quota deductions are persisted and usage tracking remains accurate. You can see similar commit patterns in provider management code here and the event handler logic here.

To reply, just mention @dosu.

How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other  Chat with Dosu Join Discord Share on X

@dosubot[bot] commented on GitHub (Aug 22, 2025): <!-- Answer --> The provider update handler for quota deductions is implemented in `api/events/event_handlers/update_provider_when_message_created.py`. The function `_execute_provider_updates` uses a SQLAlchemy `Session` context manager (`with Session(db.engine) as session:`) to execute updates, but does not explicitly call `session.commit()`. While the context manager should commit on exit if no exceptions occur, missing or unreliable commits can cause quota updates to not persist as you've observed. To fix this, add an explicit `session.commit()` at the end of the update loop in `_execute_provider_updates`, after all updates are executed. This matches best practices used elsewhere in the codebase for provider updates and ensures changes are reliably saved to the database. For example: ```python with Session(db.engine) as session: # ... perform updates ... session.commit() ``` This change will ensure quota deductions are persisted and usage tracking remains accurate. You can see similar commit patterns in provider management code [here](https://github.com/langgenius/dify/blob/ffe1685b5426d6a5fa3daa45e75a0d9882133b2d/api/core/provider_manager.py) and the event handler logic [here](https://github.com/langgenius/dify/blob/ffe1685b5426d6a5fa3daa45e75a0d9882133b2d/api/events/event_handlers/update_provider_when_message_created.py). <!-- Dosu Comment Footer --> *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).* --- <sup>How did I do? [Good](https://app.dosu.dev/response-feedback/cd037a68-1a55-4454-9a27-225744fd8296?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/cd037a68-1a55-4454-9a27-225744fd8296?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/cd037a68-1a55-4454-9a27-225744fd8296?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/cd037a68-1a55-4454-9a27-225744fd8296?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/cd037a68-1a55-4454-9a27-225744fd8296?feedback_type=hallucination) | [Report 🐛](https://app.dosu.dev/response-feedback/cd037a68-1a55-4454-9a27-225744fd8296?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/cd037a68-1a55-4454-9a27-225744fd8296?feedback_type=other)</sup>&nbsp;&nbsp;[![Chat with Dosu](https://dosu.dev/dosu-chat-badge.svg)](https://app.dosu.dev/6088a4f4-073a-43f3-b3d4-4f06fb0c05a0/ask?utm_source=github)&nbsp;[![Join Discord](https://img.shields.io/badge/join-5865F2?logo=discord&logoColor=white&label=)](https://go.dosu.dev/discord-bot)&nbsp;[![Share on X](https://img.shields.io/badge/X-share-black)](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/langgenius/dify/issues/24356)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label 🐞 bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#16362
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?