langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 03:55:25 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[Chore/Refactor] clean some # type: ignore #16421

New Issue
Open
opened 2026-02-21 19:26:03 -05:00 by yindo · 3 comments
yindo commented 2026-02-21 19:26:03 -05:00
Owner
Copy Link
Copy Source

Originally created by @asukaminato0721 on GitHub (Aug 25, 2025).

Self Checks

  • I have read the Contributing Guide and Language Policy.
  • This is only for refactoring, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：）
  • Please do not modify this template :) and fill in all the required fields.

Description

Remove so more type check can happen.

Motivation

Robust

Additional Context

example #24649

Originally created by @asukaminato0721 on GitHub (Aug 25, 2025). ### Self Checks - [x] I have read the [Contributing Guide](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) and [Language Policy](https://github.com/langgenius/dify/issues/1542). - [x] This is only for refactoring, if you would like to ask a question, please head to [Discussions](https://github.com/langgenius/dify/discussions/categories/general). - [x] I have searched for existing issues [search for existing issues](https://github.com/langgenius/dify/issues), including closed ones. - [x] I confirm that I am using English to submit this report, otherwise it will be closed. - [x] 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：） - [x] Please do not modify this template :) and fill in all the required fields. ### Description Remove so more type check can happen. ### Motivation Robust ### Additional Context example #24649
yindo added the good first issue label 2026-02-21 19:26:03 -05:00
yindo commented 2026-02-21 19:26:04 -05:00
Author
Owner
Copy Link
Copy Source

@bowenliang123 commented on GitHub (Aug 28, 2025):

Thanks for linking #24712 as a subtask to this issue. I didn't notice this existed one before.
And I would like to leave the left cleanups to you as you scheduled.

@bowenliang123 commented on GitHub (Aug 28, 2025): Thanks for linking #24712 as a subtask to this issue. I didn't notice this existed one before. And I would like to leave the left cleanups to you as you scheduled.
yindo commented 2026-02-21 19:26:04 -05:00
Author
Owner
Copy Link
Copy Source

@Haidarabbas731 commented on GitHub (Sep 27, 2025):

Hi, I would like to contribute. Do let me know if I can do something. Thanks!

@Haidarabbas731 commented on GitHub (Sep 27, 2025): Hi, I would like to contribute. Do let me know if I can do something. Thanks!
yindo commented 2026-02-21 19:26:04 -05:00
Author
Owner
Copy Link
Copy Source

@asukaminato0721 commented on GitHub (Sep 27, 2025):

Hi, I would like to contribute. Do let me know if I can do something. Thanks!

yeah, you can try to remove some type ignore and try to fix the error, some examples are in the related pr.

@asukaminato0721 commented on GitHub (Sep 27, 2025): > Hi, I would like to contribute. Do let me know if I can do something. Thanks! yeah, you can try to remove some type ignore and try to fix the error, some examples are in the related pr.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label good first issue
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#16421
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?