langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 03:55:25 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[Chore/Refactor] adapt dead code check #16422

New Issue
Open
opened 2026-02-21 19:26:03 -05:00 by yindo · 2 comments
yindo commented 2026-02-21 19:26:03 -05:00
Owner
Copy Link
Copy Source

Originally created by @asukaminato0721 on GitHub (Aug 25, 2025).

Self Checks

  • I have read the Contributing Guide and Language Policy.
  • This is only for refactoring, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：）
  • Please do not modify this template :) and fill in all the required fields.

Description

Remove some unused function left before.

Motivation

Keep codebase clean

Additional Context

https://github.com/astral-sh/ruff/issues/872
https://github.com/jendrikseipp/vulture?tab=readme-ov-file

Originally created by @asukaminato0721 on GitHub (Aug 25, 2025). ### Self Checks - [x] I have read the [Contributing Guide](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) and [Language Policy](https://github.com/langgenius/dify/issues/1542). - [x] This is only for refactoring, if you would like to ask a question, please head to [Discussions](https://github.com/langgenius/dify/discussions/categories/general). - [x] I have searched for existing issues [search for existing issues](https://github.com/langgenius/dify/issues), including closed ones. - [x] I confirm that I am using English to submit this report, otherwise it will be closed. - [x] 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：） - [x] Please do not modify this template :) and fill in all the required fields. ### Description Remove some unused function left before. ### Motivation Keep codebase clean ### Additional Context https://github.com/astral-sh/ruff/issues/872 https://github.com/jendrikseipp/vulture?tab=readme-ov-file
yindo added the stale label 2026-02-21 19:26:03 -05:00
yindo commented 2026-02-21 19:26:04 -05:00
Author
Owner
Copy Link
Copy Source

@asukaminato0721 commented on GitHub (Aug 26, 2025):

as a record for #20999

uvx vulture  --exclude "*/tests/*.py,*/.venv/*.py,*/migrations/**/*.py"

can find out them.

@asukaminato0721 commented on GitHub (Aug 26, 2025): as a record for #20999 ``` uvx vulture --exclude "*/tests/*.py,*/.venv/*.py,*/migrations/**/*.py" ``` can find out them.
yindo commented 2026-02-21 19:26:04 -05:00
Author
Owner
Copy Link
Copy Source

@dosubot[bot] commented on GitHub (Sep 26, 2025):

Hi, @asukaminato0721. I'm Dosu, and I'm helping the Dify team manage their backlog and am marking this issue as stale.

Issue Summary:

  • You proposed refactoring the codebase by removing unused functions to improve maintainability.
  • You referenced tools like Ruff and Vulture for detecting dead code.
  • You shared a specific Vulture command to identify unused code while excluding certain directories.
  • This was a follow-up to issue #20999, aiming to keep the code cleaner and easier to manage.
  • There has been no further discussion or maintainer feedback on this issue.

Next Steps:

  • Please let me know if this issue is still relevant to the latest version of Dify by commenting here.
  • Otherwise, this issue will be automatically closed in 15 days.

Thank you for your understanding and contribution!

@dosubot[bot] commented on GitHub (Sep 26, 2025): Hi, @asukaminato0721. I'm [Dosu](https://dosu.dev), and I'm helping the Dify team manage their backlog and am marking this issue as stale. **Issue Summary:** - You proposed refactoring the codebase by removing unused functions to improve maintainability. - You referenced tools like Ruff and Vulture for detecting dead code. - You shared a specific Vulture command to identify unused code while excluding certain directories. - This was a follow-up to issue #20999, aiming to keep the code cleaner and easier to manage. - There has been no further discussion or maintainer feedback on this issue. **Next Steps:** - Please let me know if this issue is still relevant to the latest version of Dify by commenting here. - Otherwise, this issue will be automatically closed in 15 days. Thank you for your understanding and contribution!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label stale
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#16422
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?