langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

ty check CI action should be skipped when api code unchanged #16652

New Issue
Closed
opened 2026-02-21 19:27:04 -05:00 by yindo · 1 comment
yindo commented 2026-02-21 19:27:04 -05:00
Owner
Copy Link
Copy Source

Originally created by @bowenliang123 on GitHub (Sep 2, 2025).

Self Checks

  • I have read the Contributing Guide and Language Policy.
  • This is only for bug report, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：）
  • Please do not modify this template :) and fill in all the required fields.

Dify version

main

Cloud or Self Hosted

Self Hosted (Source)

Steps to reproduce

✔️ Expected Behavior

  • ty check CI action should be skipped when api code unchanged

❌ Actual Behavior

+++ realpath dev/ty-check
++ dirname /home/runner/work/dify/dify/dev/ty-check

  • SCRIPT_DIR=/home/runner/work/dify/dify/dev
  • cd /home/runner/work/dify/dify/dev/..
  • uv run --directory api --dev ty check
    dev/ty-check: line 9: uv: command not found
Originally created by @bowenliang123 on GitHub (Sep 2, 2025). ### Self Checks - [x] I have read the [Contributing Guide](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) and [Language Policy](https://github.com/langgenius/dify/issues/1542). - [x] This is only for bug report, if you would like to ask a question, please head to [Discussions](https://github.com/langgenius/dify/discussions/categories/general). - [x] I have searched for existing issues [search for existing issues](https://github.com/langgenius/dify/issues), including closed ones. - [x] I confirm that I am using English to submit this report, otherwise it will be closed. - [x] 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：） - [x] Please do not modify this template :) and fill in all the required fields. ### Dify version main ### Cloud or Self Hosted Self Hosted (Source) ### Steps to reproduce - ty check CI action should be skipped when api code unchanged - error log: https://github.com/langgenius/dify/actions/runs/17397944578/job/49384533751?pr=24984#step:6:10 ### ✔️ Expected Behavior - ty check CI action should be skipped when api code unchanged ### ❌ Actual Behavior +++ realpath dev/ty-check ++ dirname /home/runner/work/dify/dify/dev/ty-check + SCRIPT_DIR=/home/runner/work/dify/dify/dev + cd /home/runner/work/dify/dify/dev/.. + uv run --directory api --dev ty check dev/ty-check: line 9: uv: command not found
yindo closed this issue 2026-02-21 19:27:04 -05:00
yindo commented 2026-02-21 19:27:04 -05:00
Author
Owner
Copy Link
Copy Source

@dosubot[bot] commented on GitHub (Sep 2, 2025):

The 'ty check' CI action is already set up to be skipped when API code is unchanged. This is handled by the workflow using the tj-actions/changed-files action, which ensures the check only runs if files under api/** or .github/workflows/style.yml have changed. The relevant steps, including setting up uv, installing dependencies, and running dev/ty-check, are all gated by this condition .github/workflows/style.yml.

If you're seeing the uv: command not found error, it means the CI environment didn't set up uv before running the check. This can happen if the setup step is skipped or fails. Make sure the astral-sh/setup-uv@v6 step runs successfully before dev/ty-check. If you want extra safety, you could add a check for uv in the dev/ty-check script itself, similar to how it's done in dev/sync-uv dev/sync-uv.

Recent changes in the repo confirm this logic and show that the workflow is designed to skip the check unless relevant files change, and that the error is due to missing setup for uv rather than the skipping logic itself PR #24653.

To reply, just mention @dosu.

How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other  Chat with Dosu Join Discord Share on X

@dosubot[bot] commented on GitHub (Sep 2, 2025): <!-- Answer --> The 'ty check' CI action is already set up to be skipped when API code is unchanged. This is handled by the workflow using the `tj-actions/changed-files` action, which ensures the check only runs if files under `api/**` or `.github/workflows/style.yml` have changed. The relevant steps, including setting up `uv`, installing dependencies, and running `dev/ty-check`, are all gated by this condition [`.github/workflows/style.yml`](https://github.com/langgenius/dify/blob/af88266212f74bc56b25e0ede6589cc8967df555/.github/workflows/style.yml). If you're seeing the `uv: command not found` error, it means the CI environment didn't set up `uv` before running the check. This can happen if the setup step is skipped or fails. Make sure the `astral-sh/setup-uv@v6` step runs successfully before `dev/ty-check`. If you want extra safety, you could add a check for `uv` in the `dev/ty-check` script itself, similar to how it's done in `dev/sync-uv` [`dev/sync-uv`](https://github.com/langgenius/dify/blob/af88266212f74bc56b25e0ede6589cc8967df555/dev/sync-uv). Recent changes in the repo confirm this logic and show that the workflow is designed to skip the check unless relevant files change, and that the error is due to missing setup for `uv` rather than the skipping logic itself [`PR #24653`](https://github.com/langgenius/dify/pull/24653). <!-- Dosu Comment Footer --> *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).* --- <sup>How did I do? [Good](https://app.dosu.dev/response-feedback/64674bce-a9a2-4e3e-9b2c-f3e64613d467?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/64674bce-a9a2-4e3e-9b2c-f3e64613d467?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/64674bce-a9a2-4e3e-9b2c-f3e64613d467?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/64674bce-a9a2-4e3e-9b2c-f3e64613d467?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/64674bce-a9a2-4e3e-9b2c-f3e64613d467?feedback_type=hallucination) | [Report 🐛](https://app.dosu.dev/response-feedback/64674bce-a9a2-4e3e-9b2c-f3e64613d467?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/64674bce-a9a2-4e3e-9b2c-f3e64613d467?feedback_type=other)</sup>&nbsp;&nbsp;[![Chat with Dosu](https://dosu.dev/dosu-chat-badge.svg)](https://app.dosu.dev/6088a4f4-073a-43f3-b3d4-4f06fb0c05a0/ask?utm_source=github)&nbsp;[![Join Discord](https://img.shields.io/badge/join-5865F2?logo=discord&logoColor=white&label=)](https://go.dosu.dev/discord-bot)&nbsp;[![Share on X](https://img.shields.io/badge/X-share-black)](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/langgenius/dify/issues/24988)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#16652
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?