langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 03:55:25 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[Chore/Refactor] Move Basedpyright checks to style workflow and update command syntax #16681

New Issue
Closed
opened 2026-02-21 19:27:09 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 19:27:09 -05:00
Owner
Copy Link
Copy Source

Originally created by @laipz8200 on GitHub (Sep 3, 2025).

Originally assigned to: @laipz8200 on GitHub.

Self Checks

  • I have read the Contributing Guide and Language Policy.
  • This is only for refactoring, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：）
  • Please do not modify this template :) and fill in all the required fields.

Description

Refactor the CI configuration to consolidate type checking workflows and update the basedpyright command to use consistent syntax across all scripts.

Motivation

The current CI configuration has type checking split across multiple workflows. Moving the Basedpyright checks from the api-tests workflow to the style workflow creates better separation of concerns - keeping all code quality checks (linting, formatting, type checking) in one workflow while the api-tests workflow focuses purely on testing. Additionally, updating the command syntax ensures consistency with other uv commands in the project.

Additional Context

This change involves:

  1. Removing Basedpyright checks from the api-tests workflow
  2. Adding Basedpyright checks to the style workflow (replacing the ty-check step)
  3. Updating the basedpyright-check script to use --dev flag for consistency
Originally created by @laipz8200 on GitHub (Sep 3, 2025). Originally assigned to: @laipz8200 on GitHub. ## Self Checks - [x] I have read the [Contributing Guide](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) and [Language Policy](https://github.com/langgenius/dify/issues/1542). - [x] This is only for refactoring, if you would like to ask a question, please head to [Discussions](https://github.com/langgenius/dify/discussions/categories/general). - [x] I have searched for existing issues [search for existing issues](https://github.com/langgenius/dify/issues), including closed ones. - [x] I confirm that I am using English to submit this report, otherwise it will be closed. - [x] 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：） - [x] Please do not modify this template :) and fill in all the required fields. ## Description Refactor the CI configuration to consolidate type checking workflows and update the basedpyright command to use consistent syntax across all scripts. ## Motivation The current CI configuration has type checking split across multiple workflows. Moving the Basedpyright checks from the api-tests workflow to the style workflow creates better separation of concerns - keeping all code quality checks (linting, formatting, type checking) in one workflow while the api-tests workflow focuses purely on testing. Additionally, updating the command syntax ensures consistency with other uv commands in the project. ## Additional Context This change involves: 1. Removing Basedpyright checks from the api-tests workflow 2. Adding Basedpyright checks to the style workflow (replacing the ty-check step) 3. Updating the basedpyright-check script to use --dev flag for consistency
yindo closed this issue 2026-02-21 19:27:09 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#16681
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?