langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

incorrect indent in TokenBufferMemory #16770

New Issue
Closed
opened 2026-02-21 19:27:32 -05:00 by yindo · 3 comments
yindo commented 2026-02-21 19:27:32 -05:00
Owner
Copy Link
Copy Source

Originally created by @IthacaDream on GitHub (Sep 4, 2025).

Self Checks

  • I have read the Contributing Guide and Language Policy.
  • This is only for bug report, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：）
  • Please do not modify this template :) and fill in all the required fields.

Dify version

2.0.0-beta.1

Cloud or Self Hosted

Self Hosted (Source)

Steps to reproduce

incorrect indent in TokenBufferMemory, which leads an error: Run failed: cannot access local variable 'curr_message_tokens' where it is not associated with a value

https://github.com/langgenius/dify/blob/1a81c798528a4063475de4076e8cf7f7e532a111/api/core/memory/token_buffer_memory.py#L169-L181

✔️ Expected Behavior

correct indent in TokenBufferMemory

❌ Actual Behavior

No response

Originally created by @IthacaDream on GitHub (Sep 4, 2025). ### Self Checks - [x] I have read the [Contributing Guide](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) and [Language Policy](https://github.com/langgenius/dify/issues/1542). - [x] This is only for bug report, if you would like to ask a question, please head to [Discussions](https://github.com/langgenius/dify/discussions/categories/general). - [x] I have searched for existing issues [search for existing issues](https://github.com/langgenius/dify/issues), including closed ones. - [x] I confirm that I am using English to submit this report, otherwise it will be closed. - [x] 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：） - [x] Please do not modify this template :) and fill in all the required fields. ### Dify version 2.0.0-beta.1 ### Cloud or Self Hosted Self Hosted (Source) ### Steps to reproduce incorrect indent in TokenBufferMemory, which leads an error: `Run failed: cannot access local variable 'curr_message_tokens' where it is not associated with a value` https://github.com/langgenius/dify/blob/1a81c798528a4063475de4076e8cf7f7e532a111/api/core/memory/token_buffer_memory.py#L169-L181 ### ✔️ Expected Behavior correct indent in TokenBufferMemory ### ❌ Actual Behavior _No response_
yindo added the 🐞 bug label 2026-02-21 19:27:32 -05:00
yindo closed this issue 2026-02-21 19:27:32 -05:00
yindo commented 2026-02-21 19:27:32 -05:00
Author
Owner
Copy Link
Copy Source

@dosubot[bot] commented on GitHub (Sep 4, 2025):

I checked the code in question and the indentation in the TokenBufferMemory class (lines 169–181) is correct and follows Python conventions. The while loop and its body are properly nested inside the if statement, and the return statement is aligned as expected. There shouldn't be any syntax or runtime errors due to indentation in this section. If you still see an indentation issue, it might be due to local changes, editor settings, or a different branch. If possible, please share a screenshot or more details so I can help further.
View the code here.

To reply, just mention @dosu.

How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other  Chat with Dosu Join Discord Share on X

@dosubot[bot] commented on GitHub (Sep 4, 2025): <!-- Answer --> I checked the code in question and the indentation in the TokenBufferMemory class (lines 169–181) is correct and follows Python conventions. The while loop and its body are properly nested inside the if statement, and the return statement is aligned as expected. There shouldn't be any syntax or runtime errors due to indentation in this section. If you still see an indentation issue, it might be due to local changes, editor settings, or a different branch. If possible, please share a screenshot or more details so I can help further. [View the code here.](https://github.com/langgenius/dify/blob/f0561c0c3bdccfb60b549aad6da81621cfea873e/api/core/memory/token_buffer_memory.py) <!-- Dosu Comment Footer --> *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).* --- <sup>How did I do? [Good](https://app.dosu.dev/response-feedback/ea35daa2-6dba-4ab6-9069-64400cc0214a?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/ea35daa2-6dba-4ab6-9069-64400cc0214a?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/ea35daa2-6dba-4ab6-9069-64400cc0214a?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/ea35daa2-6dba-4ab6-9069-64400cc0214a?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/ea35daa2-6dba-4ab6-9069-64400cc0214a?feedback_type=hallucination) | [Report 🐛](https://app.dosu.dev/response-feedback/ea35daa2-6dba-4ab6-9069-64400cc0214a?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/ea35daa2-6dba-4ab6-9069-64400cc0214a?feedback_type=other)</sup>&nbsp;&nbsp;[![Chat with Dosu](https://dosu.dev/dosu-chat-badge.svg)](https://app.dosu.dev/6088a4f4-073a-43f3-b3d4-4f06fb0c05a0/ask?utm_source=github)&nbsp;[![Join Discord](https://img.shields.io/badge/join-5865F2?logo=discord&logoColor=white&label=)](https://go.dosu.dev/discord-bot)&nbsp;[![Share on X](https://img.shields.io/badge/X-share-black)](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/langgenius/dify/issues/25214)
yindo commented 2026-02-21 19:27:32 -05:00
Author
Owner
Copy Link
Copy Source

@IthacaDream commented on GitHub (Sep 5, 2025):

merged

@IthacaDream commented on GitHub (Sep 5, 2025): merged
yindo commented 2026-02-21 19:27:32 -05:00
Author
Owner
Copy Link
Copy Source

@shy20221121 commented on GitHub (Sep 6, 2025):

Image the same problem
@shy20221121 commented on GitHub (Sep 6, 2025): <img width="424" height="413" alt="Image" src="https://github.com/user-attachments/assets/e80c124c-2bcb-4431-b192-31f3cdba64af" /> the same problem
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label 🐞 bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#16770
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?