langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 03:55:25 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

Dify Web compiles when it shouldn't #16867

New Issue
Closed
opened 2026-02-21 19:28:28 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 19:28:28 -05:00
Owner
Copy Link
Copy Source

Originally created by @DavideDelbianco on GitHub (Sep 7, 2025).

Self Checks

  • I have read the Contributing Guide and Language Policy.
  • This is only for bug report, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：）
  • Please do not modify this template :) and fill in all the required fields.

Dify version

1.8.1

Cloud or Self Hosted

Self Hosted (Source)

Steps to reproduce

I've inspected code and there are various parts of the web project that have errors and should not compile, i guess some checks are being disabled to force it to compile?

for example in the Chat component there's the OnRegenerate callback that tries to send:

onRegenerate?.(item, { message: editedContent, files: message_files })

when it is supposed to accept

export type OnRegenerate = (chatItem: ChatItem) => void

or the chat input text area that attempts to use a callback that does not exists (probably because it was replaced with the react-textarea-autosize):

onResize={handleTextareaResize}

in the new component, the callback is

onHeightChange?: (height: number, meta: TextareaHeightChangeMeta) => void;

I guess handleTextareaResize should be removed since it clearly serves no purpose with a textarea that handles its own resizing

the <em-emoji /> that would need proper typing with a .d.ts declaration that extends JSX

and more...

✔️ Expected Behavior

The frontend should not have errors in the components, and should not be compiled with errors.

❌ Actual Behavior

frontend can compile even if it has errors creating components ready to crash react when a user meets one of them

Originally created by @DavideDelbianco on GitHub (Sep 7, 2025). ### Self Checks - [x] I have read the [Contributing Guide](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) and [Language Policy](https://github.com/langgenius/dify/issues/1542). - [x] This is only for bug report, if you would like to ask a question, please head to [Discussions](https://github.com/langgenius/dify/discussions/categories/general). - [x] I have searched for existing issues [search for existing issues](https://github.com/langgenius/dify/issues), including closed ones. - [x] I confirm that I am using English to submit this report, otherwise it will be closed. - [x] 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：） - [x] Please do not modify this template :) and fill in all the required fields. ### Dify version 1.8.1 ### Cloud or Self Hosted Self Hosted (Source) ### Steps to reproduce I've inspected code and there are various parts of the web project that have errors and should not compile, i guess some checks are being disabled to force it to compile? for example in the Chat component there's the OnRegenerate callback that tries to send: ```ts onRegenerate?.(item, { message: editedContent, files: message_files }) ``` when it is supposed to accept ```ts export type OnRegenerate = (chatItem: ChatItem) => void ``` or the chat input text area that attempts to use a callback that does not exists (probably because it was replaced with the `react-textarea-autosize`): ```ts onResize={handleTextareaResize} ``` in the new component, the callback is ```ts onHeightChange?: (height: number, meta: TextareaHeightChangeMeta) => void; ``` I guess `handleTextareaResize` should be removed since it clearly serves no purpose with a textarea that handles its own resizing the `<em-emoji />` that would need proper typing with a .d.ts declaration that extends JSX and more... ### ✔️ Expected Behavior The frontend should not have errors in the components, and should not be compiled with errors. ### ❌ Actual Behavior frontend can compile even if it has errors creating components ready to crash react when a user meets one of them
yindo added the 🐞 bug label 2026-02-21 19:28:28 -05:00
yindo closed this issue 2026-02-21 19:28:28 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label 🐞 bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#16867
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?