langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

Fix test instability in disable_segments_from_index_task tests #17455

New Issue
Closed
opened 2026-02-21 19:35:37 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 19:35:37 -05:00
Owner
Copy Link
Copy Source

Originally created by @laipz8200 on GitHub (Sep 15, 2025).

Originally assigned to: @laipz8200 on GitHub.

Summary

The integration tests for disable_segments_from_index_task have a potential instability issue due to order-dependent assertions when comparing segment node IDs.

Problem

The database query in disable_segments_from_index_task.py doesn't specify an ORDER BY clause when fetching segments, which means the results can be returned in any order. However, the tests were comparing the node IDs as ordered lists, which could cause intermittent test failures depending on database behavior.

Solution

Update the test assertions to compare node IDs as sets instead of lists, since the order doesn't affect the correctness of the clean() operation. This ensures the tests remain stable regardless of the order in which the database returns the segments.

Originally created by @laipz8200 on GitHub (Sep 15, 2025). Originally assigned to: @laipz8200 on GitHub. ## Summary The integration tests for `disable_segments_from_index_task` have a potential instability issue due to order-dependent assertions when comparing segment node IDs. ## Problem The database query in `disable_segments_from_index_task.py` doesn't specify an `ORDER BY` clause when fetching segments, which means the results can be returned in any order. However, the tests were comparing the node IDs as ordered lists, which could cause intermittent test failures depending on database behavior. ## Solution Update the test assertions to compare node IDs as sets instead of lists, since the order doesn't affect the correctness of the `clean()` operation. This ensures the tests remain stable regardless of the order in which the database returns the segments.
yindo closed this issue 2026-02-21 19:35:37 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#17455
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?