langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-22 12:36:14 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

Fix: use data.type instead of type when checking datasource node #17773

New Issue
Closed
opened 2026-02-21 19:39:36 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 19:39:36 -05:00
Owner
Copy Link
Copy Source

Originally created by @hyongtao-code on GitHub (Sep 19, 2025).

Self Checks

  • I have read the Contributing Guide and Language Policy.
  • This is only for refactoring, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：）
  • Please do not modify this template :) and fill in all the required fields.

Description

Found a bug where datasource nodes were incorrectly checked using the top-level type field instead of data.type.

In the workflow graph JSON, nodes have the following structure:

- id: '1752479895761'
  type: custom                # UI/rendering type
  data:
    type: datasource          # actual business type
    datasource_name: upload-file
    ...

The top-level type is always "custom" (for React Flow rendering), while the actual node semantics (e.g. datasource, knowledge-index) live in data.type.

Motivation

No response

Additional Context

No response

Originally created by @hyongtao-code on GitHub (Sep 19, 2025). ### Self Checks - [x] I have read the [Contributing Guide](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) and [Language Policy](https://github.com/langgenius/dify/issues/1542). - [x] This is only for refactoring, if you would like to ask a question, please head to [Discussions](https://github.com/langgenius/dify/discussions/categories/general). - [x] I have searched for existing issues [search for existing issues](https://github.com/langgenius/dify/issues), including closed ones. - [x] I confirm that I am using English to submit this report, otherwise it will be closed. - [x] 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：） - [x] Please do not modify this template :) and fill in all the required fields. ### Description Found a bug where datasource nodes were incorrectly checked using the top-level `type` field instead of `data.type`. In the workflow graph JSON, nodes have the following structure: ```yaml - id: '1752479895761' type: custom # UI/rendering type data: type: datasource # actual business type datasource_name: upload-file ... ``` The top-level type is always "custom" (for React Flow rendering), while the actual node semantics (e.g. datasource, knowledge-index) live in data.type. ### Motivation _No response_ ### Additional Context _No response_
yindo added the 🐞 bugrefactor labels 2026-02-21 19:39:36 -05:00
yindo closed this issue 2026-02-21 19:39:36 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label refactor 🐞 bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#17773
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?