langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[Chore/Refactor] Simplify web package.json lint scripts #18246

New Issue
Closed
opened 2026-02-21 19:45:22 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 19:45:22 -05:00
Owner
Copy Link
Copy Source

Originally created by @lyzno1 on GitHub (Sep 25, 2025).

Description

The web/package.json file contains redundant lint scripts that create maintenance overhead and confusion for developers. Specifically:

  • lint and eslint scripts are identical duplicates
  • Mixed naming conventions (lint-* vs eslint-*)
  • Inconsistent configuration across similar scripts
  • 7 total lint scripts when 4 would suffice

Motivation

This refactor is necessary to:

  1. Reduce maintenance burden: Fewer scripts mean less configuration to maintain
  2. Improve developer experience: Clear, consistent naming makes scripts easier to understand
  3. Standardize configuration: Consistent caching and concurrency settings across all lint scripts
  4. Follow best practices: Align with common npm script naming conventions

Proposed Changes

Consolidate the current 7 lint scripts into 4 standardized scripts:

{
  "lint": "eslint --concurrency=auto --cache --cache-location node_modules/.cache/eslint/.eslint-cache",
  "lint:fix": "eslint --concurrency=auto --cache --cache-location node_modules/.cache/eslint/.eslint-cache --fix",
  "lint:quiet": "eslint --concurrency=auto --cache --cache-location node_modules/.cache/eslint/.eslint-cache --quiet",
  "lint:complexity": "eslint --concurrency=auto --rule 'complexity: [error, {max: 15}]' --quiet"
}

Additional Context

This refactor maintains all existing functionality while improving maintainability. The standardized naming convention (lint:*) follows npm best practices and makes the scripts more intuitive for new contributors.

Originally created by @lyzno1 on GitHub (Sep 25, 2025). ## Description The web/package.json file contains redundant lint scripts that create maintenance overhead and confusion for developers. Specifically: - `lint` and `eslint` scripts are identical duplicates - Mixed naming conventions (`lint-*` vs `eslint-*`) - Inconsistent configuration across similar scripts - 7 total lint scripts when 4 would suffice ## Motivation This refactor is necessary to: 1. **Reduce maintenance burden**: Fewer scripts mean less configuration to maintain 2. **Improve developer experience**: Clear, consistent naming makes scripts easier to understand 3. **Standardize configuration**: Consistent caching and concurrency settings across all lint scripts 4. **Follow best practices**: Align with common npm script naming conventions ## Proposed Changes Consolidate the current 7 lint scripts into 4 standardized scripts: ```json { "lint": "eslint --concurrency=auto --cache --cache-location node_modules/.cache/eslint/.eslint-cache", "lint:fix": "eslint --concurrency=auto --cache --cache-location node_modules/.cache/eslint/.eslint-cache --fix", "lint:quiet": "eslint --concurrency=auto --cache --cache-location node_modules/.cache/eslint/.eslint-cache --quiet", "lint:complexity": "eslint --concurrency=auto --rule 'complexity: [error, {max: 15}]' --quiet" } ``` ## Additional Context This refactor maintains all existing functionality while improving maintainability. The standardized naming convention (`lint:*`) follows npm best practices and makes the scripts more intuitive for new contributors.
yindo closed this issue 2026-02-21 19:45:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#18246
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?