langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

missing arg in route #18581

New Issue
Closed
opened 2026-02-21 19:49:25 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 19:49:25 -05:00
Owner
Copy Link
Copy Source

Originally created by @asukaminato0721 on GitHub (Sep 29, 2025).

high

While the refactoring to use @ns.route is a good change, there appears to be a pre-existing issue in the patch method of this TagUpdateDeleteApi class. The call to TagService.update_tags on line 65 passes args that only contain the tag name. The service method TagService.update_tags seems to expect a type field in args to perform the uniqueness check for the tag name. Since type is missing, the validation is skipped, which could allow duplicate tag names to be created. This is not a bug introduced by this PR, but it would be beneficial to fix it to ensure data integrity.

Originally posted by @gemini-code-assist[bot] in https://github.com/langgenius/dify/pull/26357#discussion_r2385077516

Originally created by @asukaminato0721 on GitHub (Sep 29, 2025). ![high](https://www.gstatic.com/codereviewagent/high-priority.svg) While the refactoring to use `@ns.route` is a good change, there appears to be a pre-existing issue in the `patch` method of this `TagUpdateDeleteApi` class. The call to `TagService.update_tags` on line 65 passes `args` that only contain the tag `name`. The service method `TagService.update_tags` seems to expect a `type` field in `args` to perform the uniqueness check for the tag name. Since `type` is missing, the validation is skipped, which could allow duplicate tag names to be created. This is not a bug introduced by this PR, but it would be beneficial to fix it to ensure data integrity. _Originally posted by @gemini-code-assist[bot] in https://github.com/langgenius/dify/pull/26357#discussion_r2385077516_
yindo added the 🐞 bug label 2026-02-21 19:49:25 -05:00
yindo closed this issue 2026-02-21 19:49:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label 🐞 bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#18581
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?