langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

/v1/datasets/tags returns 404 due to @validate_dataset_token expecting dataset_id #18826

New Issue
Closed
opened 2026-02-21 19:52:22 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 19:52:22 -05:00
Owner
Copy Link
Copy Source

Originally created by @skimhiro on GitHub (Oct 5, 2025).

Self Checks

  • I have read the Contributing Guide and Language Policy.
  • This is only for bug report, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：）
  • Please do not modify this template :) and fill in all the required fields.

Dify version

1.9.1

Cloud or Self Hosted

Self Hosted (Docker)

Steps to reproduce

Endpoint:

GET /v1/datasets/tags

Actual Response:

{
  "code": "not_found",
  "message": "Dataset not found. You have requested this URI [/v1/datasets/tags] but did you mean /v1/datasets/tags or /v1/datasets/<uuid:dataset_id>/tags or /v1/datasets/<uuid:dataset_id>/documents/<uuid:document_id>/segments/<uuid:segment_id>/child_chunks/<uuid:child_chunk_id> ?",
  "status": 404
}

🧩 Problem Description

When calling /v1/datasets/tags, the API incorrectly returns a 404 Dataset not found error.
The root cause is that the @validate_dataset_token decorator assumes the presence of a dataset_id parameter, even for endpoints that do not include one (like /datasets or /datasets/tags).

This results in a failed lookup (DatasetService.get_dataset(None)), which raises a NotFound("Dataset not found.").

✅ Expected Behavior

GET /v1/datasets/tags should return the list of knowledge-type tags successfully, as it did previously, without requiring a dataset ID.

⚙️ Root Cause

  • The decorator @validate_dataset_token is applied globally to dataset-related APIs.
  • It does not check whether dataset_id exists in the route arguments before attempting validation.
  • This causes all routes without dataset_id to fail.

🩹 Proposed Fix

Remove or bypass @validate_dataset_token for non-dataset-specific routes (e.g., /datasets, /datasets/tags).

Updated Code Example:

class DatasetTagsApi(DatasetApiResource):
    @service_api_ns.doc("list_dataset_tags")
    @service_api_ns.doc(description="Get all knowledge type tags")
    @service_api_ns.doc(
        responses={
            200: "Tags retrieved successfully",
            401: "Unauthorized - invalid API token",
        }
    )
    # @validate_dataset_token  # Removed decorator to avoid dataset_id check
    @service_api_ns.marshal_with(build_dataset_tag_fields(service_api_ns))
    def get(self, tenant_id):
        """Get all knowledge type tags."""
        assert isinstance(current_user, Account)
        cid = current_user.current_tenant_id
        assert cid is not None
        tags = TagService.get_tags("knowledge", cid)

        # Prepare response JSON
        response = []
        for tag in tags:
            binding_count = TagService.get_tag_binding_count(tag.id)
            response.append(
                {
                    "id": tag.id,
                    "name": tag.name,
                    "type": tag.type,
                    "binding_count": binding_count,
                }
            )
        return response, 200

✔️ Expected Behavior

Response

  {
    "id": "5ff031f2-0655-40b3-b955-8a057fa415d9",
    "name": "test2",
    "type": "knowledge",
    "binding_count": "1"
  },
  {
    "id": "e2d7cc22-b9b1-40cc-a135-8f81a0ea32c8",
    "name": "test",
    "type": "knowledge",
    "binding_count": "1"
  }
]

❌ Actual Behavior

No response

Originally created by @skimhiro on GitHub (Oct 5, 2025). ### Self Checks - [x] I have read the [Contributing Guide](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) and [Language Policy](https://github.com/langgenius/dify/issues/1542). - [x] This is only for bug report, if you would like to ask a question, please head to [Discussions](https://github.com/langgenius/dify/discussions/categories/general). - [x] I have searched for existing issues [search for existing issues](https://github.com/langgenius/dify/issues), including closed ones. - [x] I confirm that I am using English to submit this report, otherwise it will be closed. - [x] 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：） - [x] Please do not modify this template :) and fill in all the required fields. ### Dify version 1.9.1 ### Cloud or Self Hosted Self Hosted (Docker) ### Steps to reproduce **Endpoint:** ``` GET /v1/datasets/tags ``` **Actual Response:** ```json { "code": "not_found", "message": "Dataset not found. You have requested this URI [/v1/datasets/tags] but did you mean /v1/datasets/tags or /v1/datasets/<uuid:dataset_id>/tags or /v1/datasets/<uuid:dataset_id>/documents/<uuid:document_id>/segments/<uuid:segment_id>/child_chunks/<uuid:child_chunk_id> ?", "status": 404 } ``` --- ### 🧩 Problem Description When calling `/v1/datasets/tags`, the API incorrectly returns a `404 Dataset not found` error. The root cause is that the `@validate_dataset_token` decorator assumes the presence of a `dataset_id` parameter, even for endpoints that do not include one (like `/datasets` or `/datasets/tags`). This results in a failed lookup (`DatasetService.get_dataset(None)`), which raises a `NotFound("Dataset not found.")`. --- ### ✅ Expected Behavior `GET /v1/datasets/tags` should return the list of knowledge-type tags successfully, as it did previously, **without requiring a dataset ID**. --- ### ⚙️ Root Cause * The decorator `@validate_dataset_token` is applied globally to dataset-related APIs. * It does not check whether `dataset_id` exists in the route arguments before attempting validation. * This causes all routes without `dataset_id` to fail. --- ### 🩹 Proposed Fix Remove or bypass `@validate_dataset_token` for non-dataset-specific routes (e.g., `/datasets`, `/datasets/tags`). **Updated Code Example:** ```python class DatasetTagsApi(DatasetApiResource): @service_api_ns.doc("list_dataset_tags") @service_api_ns.doc(description="Get all knowledge type tags") @service_api_ns.doc( responses={ 200: "Tags retrieved successfully", 401: "Unauthorized - invalid API token", } ) # @validate_dataset_token # Removed decorator to avoid dataset_id check @service_api_ns.marshal_with(build_dataset_tag_fields(service_api_ns)) def get(self, tenant_id): """Get all knowledge type tags.""" assert isinstance(current_user, Account) cid = current_user.current_tenant_id assert cid is not None tags = TagService.get_tags("knowledge", cid) # Prepare response JSON response = [] for tag in tags: binding_count = TagService.get_tag_binding_count(tag.id) response.append( { "id": tag.id, "name": tag.name, "type": tag.type, "binding_count": binding_count, } ) return response, 200 ``` ### ✔️ Expected Behavior Response ```[ { "id": "5ff031f2-0655-40b3-b955-8a057fa415d9", "name": "test2", "type": "knowledge", "binding_count": "1" }, { "id": "e2d7cc22-b9b1-40cc-a135-8f81a0ea32c8", "name": "test", "type": "knowledge", "binding_count": "1" } ] ``` ### ❌ Actual Behavior _No response_
yindo added the 🐞 bug label 2026-02-21 19:52:22 -05:00
yindo closed this issue 2026-02-21 19:52:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label 🐞 bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#18826
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?