langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[Chore/Refactor] Remove unused after_request hooks from console API key controllers #19249

New Issue
Closed
opened 2026-02-21 19:57:31 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 19:57:31 -05:00
Owner
Copy Link
Copy Source

Originally created by @laipz8200 on GitHub (Oct 14, 2025).

Originally assigned to: @laipz8200 on GitHub.

  • I have read the Contributing Guide and Language Policy.
  • This is only for refactoring, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：）
  • Please do not modify this template :) and fill in all the required fields.

Description

The console API key resources under api/controllers/console/apikey.py still define after_request hooks, but Flask does not call after_request on resource classes. As a result, the CORS headers configured there are never applied and the code path is dead.

Motivation

Removing the unused hooks makes the controller easier to understand and keeps CORS behavior centralized in the correct application-level middleware.

Originally created by @laipz8200 on GitHub (Oct 14, 2025). Originally assigned to: @laipz8200 on GitHub. - [x] I have read the [Contributing Guide](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) and [Language Policy](https://github.com/langgenius/dify/issues/1542). - [x] This is only for refactoring, if you would like to ask a question, please head to [Discussions](https://github.com/langgenius/dify/discussions/categories/general). - [x] I have searched for existing issues [search for existing issues](https://github.com/langgenius/dify/issues), including closed ones. - [x] I confirm that I am using English to submit this report, otherwise it will be closed. - [x] 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：） - [x] Please do not modify this template :) and fill in all the required fields. ### Description The console API key resources under `api/controllers/console/apikey.py` still define `after_request` hooks, but Flask does not call `after_request` on resource classes. As a result, the CORS headers configured there are never applied and the code path is dead. ### Motivation Removing the unused hooks makes the controller easier to understand and keeps CORS behavior centralized in the correct application-level middleware.
yindo closed this issue 2026-02-21 19:57:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#19249
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?