langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[Chore/Refactor] Improve type safety for EasyUIBasedAppGenerateEntity.query field #20067

New Issue
Closed
opened 2026-02-21 20:05:42 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:05:42 -05:00
Owner
Copy Link
Copy Source

Originally created by @laipz8200 on GitHub (Oct 31, 2025).

Originally assigned to: @laipz8200 on GitHub.

Description

The query field in EasyUIBasedAppGenerateEntity is currently typed as str | None with a default value of None. However, after reviewing all usages throughout the codebase, this field is always treated as a string and never explicitly checked for None.

This refactor changes the type hint from str | None = None to str = "" to better reflect the actual usage pattern and improve type safety.

Motivation

  1. Type Safety: The current optional type allows None values, but the codebase always treats this field as a string. This creates potential for type-related issues and confusion.

  2. Code Clarity: Making the field non-optional with an empty string default more accurately represents how the field is used in practice.

  3. Consistency: Using a non-None default value eliminates the need for None checks throughout the codebase, making the code cleaner and more maintainable.

  4. Better Developer Experience: With a proper non-optional type hint, IDEs and type checkers can provide better autocomplete and error detection.

Originally created by @laipz8200 on GitHub (Oct 31, 2025). Originally assigned to: @laipz8200 on GitHub. ## Description The `query` field in `EasyUIBasedAppGenerateEntity` is currently typed as `str | None` with a default value of `None`. However, after reviewing all usages throughout the codebase, this field is always treated as a string and never explicitly checked for `None`. This refactor changes the type hint from `str | None = None` to `str = ""` to better reflect the actual usage pattern and improve type safety. ## Motivation 1. **Type Safety**: The current optional type allows `None` values, but the codebase always treats this field as a string. This creates potential for type-related issues and confusion. 2. **Code Clarity**: Making the field non-optional with an empty string default more accurately represents how the field is used in practice. 3. **Consistency**: Using a non-None default value eliminates the need for None checks throughout the codebase, making the code cleaner and more maintainable. 4. **Better Developer Experience**: With a proper non-optional type hint, IDEs and type checkers can provide better autocomplete and error detection.
yindo closed this issue 2026-02-21 20:05:42 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#20067
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?