langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-22 12:36:14 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[Chore/Refactor] Add SQLAlchemy mapped type hints to MessageAnnotation #20087

New Issue
Closed
opened 2026-02-21 20:05:47 -05:00 by yindo · 1 comment
yindo commented 2026-02-21 20:05:47 -05:00
Owner
Copy Link
Copy Source

Originally created by @laipz8200 on GitHub (Nov 2, 2025).

Originally assigned to: @laipz8200 on GitHub.

  • I have read the Contributing Guide and Language Policy.
  • This is only for refactoring, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：）
  • Please do not modify this template :) and fill in all the required fields.

Description

Message annotation columns still rely on implicit SQLAlchemy typing without Mapped hints, leaving static analyzers without the contract expected in this bounded context.

Motivation

Providing explicit Mapped type annotations for the message annotation entity keeps the domain model type-safe and aligned with the project-wide move toward stronger typing.

Originally created by @laipz8200 on GitHub (Nov 2, 2025). Originally assigned to: @laipz8200 on GitHub. - [x] I have read the [Contributing Guide](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) and [Language Policy](https://github.com/langgenius/dify/issues/1542). - [x] This is only for refactoring, if you would like to ask a question, please head to [Discussions](https://github.com/langgenius/dify/discussions/categories/general). - [x] I have searched for existing issues [search for existing issues](https://github.com/langgenius/dify/issues), including closed ones. - [x] I confirm that I am using English to submit this report, otherwise it will be closed. - [x] 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：） - [x] Please do not modify this template :) and fill in all the required fields. ### Description Message annotation columns still rely on implicit SQLAlchemy typing without `Mapped` hints, leaving static analyzers without the contract expected in this bounded context. ### Motivation Providing explicit `Mapped` type annotations for the message annotation entity keeps the domain model type-safe and aligned with the project-wide move toward stronger typing.
yindo closed this issue 2026-02-21 20:05:47 -05:00
yindo commented 2026-02-21 20:05:47 -05:00
Author
Owner
Copy Link
Copy Source

@dosubot[bot] commented on GitHub (Dec 4, 2025):

Hi, @laipz8200. I'm Dosu, and I'm helping the Dify team manage their backlog and am marking this issue as stale.

Issue Summary:

  • You proposed enhancing the MessageAnnotation entity by adding explicit SQLAlchemy Mapped type hints.
  • The goal is to improve type safety and enable better static analysis.
  • This aligns with the project's broader objective of stronger typing in the domain model.
  • There has been no further discussion or activity on this proposal since it was opened.

What's Next:

  • Please let me know if this issue is still relevant to the latest version of Dify by commenting here.
  • If I do not hear back within 15 days, this issue will be automatically closed.

Thank you for your understanding and contribution!

@dosubot[bot] commented on GitHub (Dec 4, 2025): Hi, @laipz8200. I'm [Dosu](https://dosu.dev), and I'm helping the Dify team manage their backlog and am marking this issue as stale. **Issue Summary:** - You proposed enhancing the MessageAnnotation entity by adding explicit SQLAlchemy `Mapped` type hints. - The goal is to improve type safety and enable better static analysis. - This aligns with the project's broader objective of stronger typing in the domain model. - There has been no further discussion or activity on this proposal since it was opened. **What's Next:** - Please let me know if this issue is still relevant to the latest version of Dify by commenting here. - If I do not hear back within 15 days, this issue will be automatically closed. Thank you for your understanding and contribution!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#20087
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?