langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

Fix ci error #20433

New Issue
Closed
opened 2026-02-21 20:07:26 -05:00 by yindo · 1 comment
yindo commented 2026-02-21 20:07:26 -05:00
Owner
Copy Link
Copy Source

Originally created by @ZeroZ-lab on GitHub (Nov 19, 2025).

Self Checks

  • I have read the Contributing Guide and Language Policy.
  • This is only for refactoring, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：）
  • Please do not modify this template :) and fill in all the required fields.

Description

=================================== FAILURES ===================================
_________ test_apply_display_status_filter_applies_when_status_present _________

def test_apply_display_status_filter_applies_when_status_present():
    query = sa.select(Document)
    filtered = DocumentService.apply_display_status_filter(query, "queuing")
    compiled = str(filtered.compile(compile_kwargs={"literal_binds": True}))
    assert "WHERE" in compiled

  assert "document.indexing_status = 'waiting'" in compiled

E assert "document.indexing_status = 'waiting'" in "SELECT documents.id, documents.tenant_id, documents.dataset_id, documents.position, documents.data_source_type, docum...oc_metadata, documents.doc_form, documents.doc_language \nFROM documents \nWHERE documents.indexing_status = 'waiting'"

api/tests/unit_tests/services/test_document_service_display_status.py:26: AssertionError

Motivation

No response

Additional Context

No response

Originally created by @ZeroZ-lab on GitHub (Nov 19, 2025). ### Self Checks - [x] I have read the [Contributing Guide](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) and [Language Policy](https://github.com/langgenius/dify/issues/1542). - [x] This is only for refactoring, if you would like to ask a question, please head to [Discussions](https://github.com/langgenius/dify/discussions/categories/general). - [x] I have searched for existing issues [search for existing issues](https://github.com/langgenius/dify/issues), including closed ones. - [x] I confirm that I am using English to submit this report, otherwise it will be closed. - [x] 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：） - [x] Please do not modify this template :) and fill in all the required fields. ### Description =================================== FAILURES =================================== _________ test_apply_display_status_filter_applies_when_status_present _________ def test_apply_display_status_filter_applies_when_status_present(): query = sa.select(Document) filtered = DocumentService.apply_display_status_filter(query, "queuing") compiled = str(filtered.compile(compile_kwargs={"literal_binds": True})) assert "WHERE" in compiled > assert "document.indexing_status = 'waiting'" in compiled E assert "document.indexing_status = 'waiting'" in "SELECT documents.id, documents.tenant_id, documents.dataset_id, documents.position, documents.data_source_type, docum...oc_metadata, documents.doc_form, documents.doc_language \nFROM documents \nWHERE documents.indexing_status = 'waiting'" api/tests/unit_tests/services/test_document_service_display_status.py:26: AssertionError ### Motivation _No response_ ### Additional Context _No response_
yindo added the 🐞 bugrefactor labels 2026-02-21 20:07:26 -05:00
yindo closed this issue 2026-02-21 20:07:26 -05:00
yindo commented 2026-02-21 20:07:27 -05:00
Author
Owner
Copy Link
Copy Source

@dosubot[bot] commented on GitHub (Nov 19, 2025):

The CI error is caused by a mismatch in the expected table name in your test assertion. The Document ORM model defines the table name as documents (plural), so the generated SQL uses documents.indexing_status = 'waiting'—not document.indexing_status = 'waiting' as your test expects. To fix the error, update your test assertion to:

assert "documents.indexing_status = 'waiting'" in compiled

This change aligns the test with the actual SQL output and the ORM model definition. The filtering logic and SQL generation are correct; only the test expectation needs updating.
Reference: Document ORM model and filter logic

To reply, just mention @dosu.

How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other  Chat with Dosu Join Discord Share on X

@dosubot[bot] commented on GitHub (Nov 19, 2025): <!-- Answer --> The CI error is caused by a mismatch in the expected table name in your test assertion. The Document ORM model defines the table name as `documents` (plural), so the generated SQL uses `documents.indexing_status = 'waiting'`—not `document.indexing_status = 'waiting'` as your test expects. To fix the error, update your test assertion to: ```python assert "documents.indexing_status = 'waiting'" in compiled ``` This change aligns the test with the actual SQL output and the ORM model definition. The filtering logic and SQL generation are correct; only the test expectation needs updating. [Reference: Document ORM model and filter logic](https://github.com/langgenius/dify/blob/f038aa474689ce83300874dcd7e6c9631e9ed490/api/models/dataset.py#L344-L346) <!-- Dosu Comment Footer --> *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).* --- <sup>How did I do? [Good](https://app.dosu.dev/response-feedback/d59ee0ca-09e8-41de-983f-01e2c57b51b8?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/d59ee0ca-09e8-41de-983f-01e2c57b51b8?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/d59ee0ca-09e8-41de-983f-01e2c57b51b8?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/d59ee0ca-09e8-41de-983f-01e2c57b51b8?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/d59ee0ca-09e8-41de-983f-01e2c57b51b8?feedback_type=hallucination) | [Report 🐛](https://app.dosu.dev/response-feedback/d59ee0ca-09e8-41de-983f-01e2c57b51b8?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/d59ee0ca-09e8-41de-983f-01e2c57b51b8?feedback_type=other)</sup>&nbsp;&nbsp;[![Chat with Dosu](https://dosu.dev/dosu-chat-badge.svg)](https://app.dosu.dev/6088a4f4-073a-43f3-b3d4-4f06fb0c05a0/ask?utm_source=github)&nbsp;[![Join Discord](https://img.shields.io/badge/join-5865F2?logo=discord&logoColor=white&label=)](https://go.dosu.dev/discord-bot)&nbsp;[![Share on X](https://img.shields.io/badge/X-share-black)](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/langgenius/dify/issues/28435)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label refactor 🐞 bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#20433
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?