langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 03:55:25 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[Chore/Refactor] Remove WEAVIATE_GRPC_ENABLED option #20787

New Issue
Open
opened 2026-02-21 20:08:59 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:08:59 -05:00
Owner
Copy Link
Copy Source

Originally created by @BorisPolonsky on GitHub (Dec 4, 2025).

Self Checks

  • I have read the Contributing Guide and Language Policy.
  • This is only for refactoring, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：）
  • Please do not modify this template :) and fill in all the required fields.

Description

Remove WEAVIATE_GRPC_ENABLED from environment variables and Dify configurations.

https://github.com/langgenius/dify/blob/693ab6ad82209f3459c2674c3203b8a175e1ce98/api/configs/middleware/vdb/weaviate_config.py#L20-L23

Motivation

For Weaviate to work with Dify, Weavaite 1.27+ and client v4 are required. There's no option to enable/disable the gRPC connection under the hood, making WEAVIATE_GRPC_ENABLED redundant and misleading.

Additional Context

The way Dify initialize client for Weaviate:
https://github.com/langgenius/dify/blob/b033bb02fc7a6981ab454615c35aefe6a56d2eae/api/core/rag/datasource/vdb/weaviate/weaviate_vector.py#L110-L119

The fact that gRPC is mandatory for weaviate.connect_to_custom:
https://github.com/weaviate/weaviate-python-client/blob/adf284a6bcf896d8cb7391ec931a9eab8ffede20/weaviate/connect/helpers.py#L282-L293

Originally created by @BorisPolonsky on GitHub (Dec 4, 2025). ### Self Checks - [x] I have read the [Contributing Guide](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) and [Language Policy](https://github.com/langgenius/dify/issues/1542). - [x] This is only for refactoring, if you would like to ask a question, please head to [Discussions](https://github.com/langgenius/dify/discussions/categories/general). - [x] I have searched for existing issues [search for existing issues](https://github.com/langgenius/dify/issues), including closed ones. - [x] I confirm that I am using English to submit this report, otherwise it will be closed. - [x] 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：） - [x] Please do not modify this template :) and fill in all the required fields. ### Description Remove `WEAVIATE_GRPC_ENABLED` from environment variables and Dify configurations. https://github.com/langgenius/dify/blob/693ab6ad82209f3459c2674c3203b8a175e1ce98/api/configs/middleware/vdb/weaviate_config.py#L20-L23 ### Motivation For Weaviate to work with Dify, Weavaite 1.27+ and client v4 are required. There's no option to enable/disable the gRPC connection under the hood, making `WEAVIATE_GRPC_ENABLED` redundant and misleading. ### Additional Context The way Dify initialize client for Weaviate: https://github.com/langgenius/dify/blob/b033bb02fc7a6981ab454615c35aefe6a56d2eae/api/core/rag/datasource/vdb/weaviate/weaviate_vector.py#L110-L119 The fact that gRPC is mandatory for `weaviate.connect_to_custom`: https://github.com/weaviate/weaviate-python-client/blob/adf284a6bcf896d8cb7391ec931a9eab8ffede20/weaviate/connect/helpers.py#L282-L293
yindo added the refactor label 2026-02-21 20:08:59 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label refactor
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#20787
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?