langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

refactor: extract useAsyncWindowOpen hook for async popup handling #20919

New Issue
Closed
opened 2026-02-21 20:09:47 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:09:47 -05:00
Owner
Copy Link
Copy Source

Originally created by @lyzno1 on GitHub (Dec 9, 2025).

Originally assigned to: @lyzno1 on GitHub.

Refactoring Opportunity

Multiple components implement the same placeholder window pattern for async popup opening. This should be extracted into a reusable hook.

Current Code Duplication

  1. billing-page/index.tsx (already correctly implemented)
  2. billing/pricing/plans/cloud-plan-item/index.tsx (needs fixing)
  3. apps/app-card.tsx (needs fixing)
  4. app/app-publisher/index.tsx (needs fixing)

Proposed Solution

Create useAsyncWindowOpen hook with:

  • Placeholder window creation in user gesture context
  • Async URL fetching
  • Window redirect or cleanup on error
  • Consistent error handling
  • TypeScript types

Benefits

  • Single source of truth for async popup logic
  • Consistent behavior across all components
  • Easier to maintain and test
  • Reusable for future scenarios
Originally created by @lyzno1 on GitHub (Dec 9, 2025). Originally assigned to: @lyzno1 on GitHub. ## Refactoring Opportunity Multiple components implement the same placeholder window pattern for async popup opening. This should be extracted into a reusable hook. ## Current Code Duplication 1. billing-page/index.tsx (already correctly implemented) 2. billing/pricing/plans/cloud-plan-item/index.tsx (needs fixing) 3. apps/app-card.tsx (needs fixing) 4. app/app-publisher/index.tsx (needs fixing) ## Proposed Solution Create useAsyncWindowOpen hook with: - Placeholder window creation in user gesture context - Async URL fetching - Window redirect or cleanup on error - Consistent error handling - TypeScript types ## Benefits - Single source of truth for async popup logic - Consistent behavior across all components - Easier to maintain and test - Reusable for future scenarios
yindo closed this issue 2026-02-21 20:09:47 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#20919
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?