langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 03:55:25 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

Feature: Pass datasource_parameters when calling get_online_document_pages for datasource plugins #21096

New Issue
Closed
opened 2026-02-21 20:10:43 -05:00 by yindo · 1 comment
yindo commented 2026-02-21 20:10:43 -05:00
Owner
Copy Link
Copy Source

Originally created by @r-hashi01 on GitHub (Dec 16, 2025).

Self Checks

  • I have read the Contributing Guide and Language Policy.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • Please do not modify this template :) and fill in all the required fields.

1. Is this request related to a challenge you're experiencing? Tell me about your story.

I'm working with the GitHub datasource plugin and noticed that datasource_parameters is always empty when get_online_document_pages is called.

What I'm seeing in the plugin daemon logs:

{
  "action": "online_document_pages",
  "datasource": "github",
  "param_keys":  [],
  "provider": "github_datasource",
  "tenant_id": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx"
}

2. Additional context or comments

Dify version: 1.11.1

3. Can you help us with this feature?

  • I am interested in contributing to this feature.
Originally created by @r-hashi01 on GitHub (Dec 16, 2025). ### Self Checks - [x] I have read the [Contributing Guide](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) and [Language Policy](https://github.com/langgenius/dify/issues/1542). - [x] I have searched for existing issues [search for existing issues](https://github.com/langgenius/dify/issues), including closed ones. - [x] I confirm that I am using English to submit this report, otherwise it will be closed. - [x] Please do not modify this template :) and fill in all the required fields. ### 1. Is this request related to a challenge you're experiencing? Tell me about your story. I'm working with the GitHub datasource plugin and noticed that `datasource_parameters` is always empty when `get_online_document_pages` is called. **What I'm seeing in the plugin daemon logs:** ```json { "action": "online_document_pages", "datasource": "github", "param_keys": [], "provider": "github_datasource", "tenant_id": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" } ``` ### 2. Additional context or comments Dify version: 1.11.1 ### 3. Can you help us with this feature? - [ ] I am interested in contributing to this feature.
yindo added the 💪 enhancement label 2026-02-21 20:10:43 -05:00
yindo closed this issue 2026-02-21 20:10:43 -05:00
yindo commented 2026-02-21 20:10:44 -05:00
Author
Owner
Copy Link
Copy Source

@dosubot[bot] commented on GitHub (Dec 16, 2025):

Hi @r-hashi01! I'm Dosu and I’m helping the dify team.

The reason datasource_parameters is always empty when get_online_document_pages is called for the GitHub datasource plugin is that, in the current Dify implementation, the service layer (specifically RagPipelineService.run_datasource_workflow_node) passes user_inputs instead of the resolved datasource_parameters or variables_map to the plugin call. As a result, even though the backend and plugin infrastructure support passing these parameters, nothing meaningful is sent down the chain, and the GitHub plugin's _get_pages method receives an empty dictionary and does not use it for filtering or selection. To address this, the service should pass the actual parameter map with user-selected values to get_online_document_pages, and the plugin should be updated to use these parameters as needed for filtering repositories or other selection logic. No merged pull requests currently address this, but the infrastructure is in place for a fix to be implemented in the service and plugin layers.
See code details
Plugin implementation

To reply, just mention @dosu.

How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other

Chat with Dosu Open in Cursor Join Discord Share on X

@dosubot[bot] commented on GitHub (Dec 16, 2025): <!-- Greeting --> Hi @r-hashi01! I'm [Dosu](https://go.dosu.dev/dosubot) and I’m helping the dify team. <!-- Answer --> The reason datasource_parameters is always empty when get_online_document_pages is called for the GitHub datasource plugin is that, in the current Dify implementation, the service layer (specifically RagPipelineService.run_datasource_workflow_node) passes user_inputs instead of the resolved datasource_parameters or variables_map to the plugin call. As a result, even though the backend and plugin infrastructure support passing these parameters, nothing meaningful is sent down the chain, and the GitHub plugin's _get_pages method receives an empty dictionary and does not use it for filtering or selection. To address this, the service should pass the actual parameter map with user-selected values to get_online_document_pages, and the plugin should be updated to use these parameters as needed for filtering repositories or other selection logic. No merged pull requests currently address this, but the infrastructure is in place for a fix to be implemented in the service and plugin layers. [See code details](https://github.com/langgenius/dify/blob/c2f2be6b086f0a15eab8961fcddc53cb353d10a5/api/services/rag_pipeline/rag_pipeline.py#L523-L588) [Plugin implementation](https://github.com/langgenius/dify-official-plugins/blob/c426921b2fc9a84857741790431e5b9113723ae2/datasources/github/datasources/github.py#L18-L166) <!-- Dosu Comment Footer --> *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).* --- <sup>How did I do? [Good](https://app.dosu.dev/response-feedback/e02da130-0f84-4fb8-9888-540189096845?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/e02da130-0f84-4fb8-9888-540189096845?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/e02da130-0f84-4fb8-9888-540189096845?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/e02da130-0f84-4fb8-9888-540189096845?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/e02da130-0f84-4fb8-9888-540189096845?feedback_type=hallucination) | [Report 🐛](https://app.dosu.dev/response-feedback/e02da130-0f84-4fb8-9888-540189096845?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/e02da130-0f84-4fb8-9888-540189096845?feedback_type=other)</sup> [![Chat with Dosu](https://dosu.dev/dosu-chat-badge.svg)](https://app.dosu.dev/6088a4f4-073a-43f3-b3d4-4f06fb0c05a0/ask?utm_source=github)&nbsp;[![Open in Cursor](https://dosu.dev/dosu-in-cursor.svg)](https://cursor.com/link/prompt?text=The%20reason%20datasource_parameters%20is%20always%20empty%20when%20get_online_document_pages%20is%20called%20for%20the%20GitHub%20datasource%20plugin%20is%20that%2C%20in%20the%20current%20Dify%20implementation%2C%20the%20service%20layer%20%28specifically%20RagPipelineService.run_datasource_workflow_node%29%20passes%20user_inputs%20instead%20of%20the%20resolved%20datasource_parameters%20or%20variables_map%20to%20the%20plugin%20call.%20As%20a%20result%2C%20even%20though%20the%20backend%20and%20plugin%20infrastructure%20support%20passing%20these%20parameters%2C%20nothing%20meaningful%20is%20sent%20down%20the%20chain%2C%20and%20the%20GitHub%20plugin%27s%20_get_pages%20method%20receives%20an%20empty%20dictionary%20and%20does%20not%20use%20it%20for%20filtering%20or%20selection.%20To%20address%20this%2C%20the%20service%20should%20pass%20the%20actual%20parameter%20map%20with%20user-selected%20values%20to%20get_online_document_pages%2C%20and%20the%20plugin%20should%20be%20updated%20to%20use%20these%20parameters%20as%20needed%20for%20filtering%20repositories%20or%20other%20selection%20logic.%20No%20merged%20pull%20requests%20currently%20address%20this%2C%20but%20the%20infrastructure%20is%20in%20place%20for%20a%20fix%20to%20be%20implemented%20in%20the%20service%20and%20plugin%20layers.%20%20%0A%5BSee%20code%20details%5D%28https%3A//github.com/langgenius/dify/blob/c2f2be6b086f0a15eab8961fcddc53cb353d10a5/api/services/rag_pipeline/rag_pipeline.py%23L523-L588%29%20%20%0A%5BPlugin%20implementation%5D%28https%3A//github.com/langgenius/dify-official-plugins/blob/c426921b2fc9a84857741790431e5b9113723ae2/datasources/github/datasources/github.py%23L18-L166%29)&nbsp;[![Join Discord](https://img.shields.io/badge/join-5865F2?logo=discord&logoColor=white&label=)](https://go.dosu.dev/discord-bot)&nbsp;[![Share on X](https://img.shields.io/badge/X-share-black)](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/langgenius/dify/issues/29756)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label 💪 enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#21096
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?