langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

docs(web): Fix misleading pnpm test command syntax in testing documentation #21246

New Issue
Closed
opened 2026-02-21 20:11:35 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:11:35 -05:00
Owner
Copy Link
Copy Source

Originally created by @lyzno1 on GitHub (Dec 23, 2025).

Summary

Fix incorrect pnpm test -- <file> command syntax in testing documentation files. The -- separator is unnecessary and potentially confusing for pnpm's argument passing behavior.

Problem

The documentation contained commands like:

pnpm test -- path/to/file.spec.tsx
pnpm test -- --coverage

This syntax is misleading because:

  • pnpm test <args> automatically appends args to the script command
  • Using -- is unnecessary and can cause confusion about pnpm/npm CLI argument distribution rules

Changes

Updated the following files to use correct syntax:

File Changes
web/testing/testing.md pnpm test -- xxx → pnpm test xxx
.claude/skills/frontend-testing/SKILL.md Same fix
.claude/skills/frontend-testing/references/checklist.md Same fix
.claude/skills/frontend-testing/references/workflow.md Same fix

Correct Usage

# Run specific file
pnpm test path/to/file.spec.tsx

# Generate coverage report  
pnpm test:coverage

# Watch mode
pnpm test:watch path/to/file.spec.tsx

Related

This is a documentation-only change, independent of any code refactoring.

Originally created by @lyzno1 on GitHub (Dec 23, 2025). ## Summary Fix incorrect `pnpm test -- <file>` command syntax in testing documentation files. The `--` separator is unnecessary and potentially confusing for pnpm's argument passing behavior. ## Problem The documentation contained commands like: ```bash pnpm test -- path/to/file.spec.tsx pnpm test -- --coverage ``` This syntax is misleading because: - `pnpm test <args>` automatically appends args to the script command - Using `--` is unnecessary and can cause confusion about pnpm/npm CLI argument distribution rules ## Changes Updated the following files to use correct syntax: | File | Changes | |------|---------| | `web/testing/testing.md` | `pnpm test -- xxx` → `pnpm test xxx` | | `.claude/skills/frontend-testing/SKILL.md` | Same fix | | `.claude/skills/frontend-testing/references/checklist.md` | Same fix | | `.claude/skills/frontend-testing/references/workflow.md` | Same fix | ## Correct Usage ```bash # Run specific file pnpm test path/to/file.spec.tsx # Generate coverage report pnpm test:coverage # Watch mode pnpm test:watch path/to/file.spec.tsx ``` ## Related This is a documentation-only change, independent of any code refactoring.
yindo added the 📚 documentation label 2026-02-21 20:11:35 -05:00
yindo closed this issue 2026-02-21 20:11:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label 📚 documentation
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#21246
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?