langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-19 08:35:20 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

enhance agent node convert_template by recursive render all str fields in AgentInput #21425

New Issue
Closed
opened 2026-02-21 20:12:29 -05:00 by yindo · 1 comment
yindo commented 2026-02-21 20:12:29 -05:00
Owner
Copy Link
Copy Source

Originally created by @hoffermei on GitHub (Jan 4, 2026).

Self Checks

  • I have read the Contributing Guide and Language Policy.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • Please do not modify this template :) and fill in all the required fields.

1. Is this request related to a challenge you're experiencing? Tell me about your story.

background

Currently variable replace mechanism is a little rough, which convert AgentValue to string by json.dumps, then replace all variable reference in string, finally convert string to original type by json.loads. Often there's \n character in variable value, which let json.loads failed.

enhance

This issure propose a new mechanism which recursive scan all field in input paramter, render only str value with convert_template

2. Additional context or comments

No response

3. Can you help us with this feature?

  • I am interested in contributing to this feature.
Originally created by @hoffermei on GitHub (Jan 4, 2026). ### Self Checks - [x] I have read the [Contributing Guide](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) and [Language Policy](https://github.com/langgenius/dify/issues/1542). - [x] I have searched for existing issues [search for existing issues](https://github.com/langgenius/dify/issues), including closed ones. - [x] I confirm that I am using English to submit this report, otherwise it will be closed. - [x] Please do not modify this template :) and fill in all the required fields. ### 1. Is this request related to a challenge you're experiencing? Tell me about your story. ## background Currently variable replace mechanism is a little rough, which convert AgentValue to string by json.dumps, then replace all variable reference in string, finally convert string to original type by json.loads. Often there's `\n` character in variable value, which let json.loads failed. ## enhance This issure propose a new mechanism which recursive scan all field in input paramter, render only str value with convert_template ### 2. Additional context or comments _No response_ ### 3. Can you help us with this feature? - [ ] I am interested in contributing to this feature.
yindo added the 💪 enhancement label 2026-02-21 20:12:29 -05:00
yindo closed this issue 2026-02-21 20:12:29 -05:00
yindo commented 2026-02-21 20:12:30 -05:00
Author
Owner
Copy Link
Copy Source

@dosubot[bot] commented on GitHub (Feb 4, 2026):

Hi, @hoffermei. I'm Dosu, and I'm helping the Dify team manage their backlog and am marking this issue as stale.

Issue Summary:

  • You suggested improving the agent node's convert_template function to recursively render all string fields in AgentInput.
  • The goal is to fix variable replacement issues when values contain newline characters.
  • No code contributions or further discussion have occurred since your proposal.
  • The issue remains unresolved and open for consideration.

Next Steps:

  • Please let me know if this issue is still relevant to the latest version of Dify by commenting here.
  • If I do not hear back within 15 days, this issue will be automatically closed.

Thank you for your understanding and contribution!

@dosubot[bot] commented on GitHub (Feb 4, 2026): Hi, @hoffermei. I'm [Dosu](https://dosu.dev), and I'm helping the Dify team manage their backlog and am marking this issue as stale. **Issue Summary:** - You suggested improving the agent node's `convert_template` function to recursively render all string fields in `AgentInput`. - The goal is to fix variable replacement issues when values contain newline characters. - No code contributions or further discussion have occurred since your proposal. - The issue remains unresolved and open for consideration. **Next Steps:** - Please let me know if this issue is still relevant to the latest version of Dify by commenting here. - If I do not hear back within 15 days, this issue will be automatically closed. Thank you for your understanding and contribution!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label 💪 enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#21425
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?