langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

perf(web): avoid unnecessary re-renders from Zustand setter subscriptions #21729

New Issue
Closed
opened 2026-02-21 20:14:03 -05:00 by yindo · 1 comment
yindo commented 2026-02-21 20:14:03 -05:00
Owner
Copy Link
Copy Source

Originally created by @lyzno1 on GitHub (Jan 17, 2026).

Problem

Components subscribe to Zustand setter functions via useStore(s => s.setXxx) but only use them in callbacks. This causes unnecessary re-render checks when store changes.

Solution

Use store.getState().setXxx() in callbacks instead of subscribing to setters.

Originally created by @lyzno1 on GitHub (Jan 17, 2026). ## Problem Components subscribe to Zustand setter functions via `useStore(s => s.setXxx)` but only use them in callbacks. This causes unnecessary re-render checks when store changes. ## Solution Use `store.getState().setXxx()` in callbacks instead of subscribing to setters.
yindo added the 💪 enhancement label 2026-02-21 20:14:03 -05:00
yindo closed this issue 2026-02-21 20:14:03 -05:00
yindo commented 2026-02-21 20:14:03 -05:00
Author
Owner
Copy Link
Copy Source

@lyzno1 commented on GitHub (Jan 17, 2026):

This improvement is unnecessary for setters; it's at most a personal engineering fastidiousness. I will open a new PR to fix the real problem: for properties that are not used by the component but are used in certain functions, they should not be obtained using selectors, but rather the corresponding "snapshot" should be obtained using getState() in the callback function.

@lyzno1 commented on GitHub (Jan 17, 2026): This improvement is unnecessary for setters; it's at most a personal engineering fastidiousness. I will open a new PR to fix the real problem: for properties that are not used by the component but are used in certain functions, they should not be obtained using selectors, but rather the corresponding "snapshot" should be obtained using getState() in the callback function.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label 💪 enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#21729
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?