langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[Refactor/Chore] Switch back to tsc in CI #21808

New Issue
Closed
opened 2026-02-21 20:14:24 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:14:24 -05:00
Owner
Copy Link
Copy Source

Originally created by @hyoban on GitHub (Jan 21, 2026).

Self Checks

  • I have read the Contributing Guide and Language Policy.
  • This is only for refactors or chores; if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：）
  • Please do not modify this template :) and fill in all the required fields.

Description

Now tsc can detect some issues that tsgo cannot.

app/components/app/annotation/batch-add-annotation-modal/csv-uploader.tsx:51:23 - error TS2488: Type 'FileList' must have a '[Symbol.iterator]()' method that returns an iterator.

51     const files = [...e.dataTransfer.files]
                         ~~~~~~~~~~~~~~~~~~~~

app/components/app/create-from-dsl-modal/uploader.tsx:61:23 - error TS2488: Type 'FileList' must have a '[Symbol.iterator]()' method that returns an iterator.

61     const files = [...e.dataTransfer.files]
                         ~~~~~~~~~~~~~~~~~~~~

app/components/apps/hooks/use-dsl-drag-drop.ts:39:23 - error TS2488: Type 'FileList' must have a '[Symbol.iterator]()' method that returns an iterator.

39     const files = [...e.dataTransfer.files]
                         ~~~~~~~~~~~~~~~~~~~~

app/components/datasets/create-from-pipeline/create-options/create-from-dsl-modal/uploader.tsx:57:23 - error TS2488: Type 'FileList' must have a '[Symbol.iterator]()' method that returns an iterator.

57     const files = [...e.dataTransfer.files]
                         ~~~~~~~~~~~~~~~~~~~~

app/components/datasets/documents/create-from-pipeline/data-source/local-file/index.tsx:233:21 - error TS2488: Type 'FileList' must have a '[Symbol.iterator]()' method that returns an iterator.

233     let files = [...e.dataTransfer.files] as File[]
                        ~~~~~~~~~~~~~~~~~~~~

app/components/datasets/documents/create-from-pipeline/data-source/local-file/index.tsx:254:21 - error TS2488: Type 'never[] | FileList' must have a '[Symbol.iterator]()' method that returns an iterator.

254     let files = [...(e.target.files ?? [])] as File[]
                        ~~~~~~~~~~~~~~~~~~~~~~

app/components/datasets/documents/detail/batch-modal/csv-uploader.tsx:129:23 - error TS2488: Type 'FileList' must have a '[Symbol.iterator]()' method that returns an iterator.

129     const files = [...e.dataTransfer.files]
                          ~~~~~~~~~~~~~~~~~~~~

app/components/plugins/plugin-page/use-uploader.ts:39:23 - error TS2488: Type 'FileList' must have a '[Symbol.iterator]()' method that returns an iterator.

39     const files = [...e.dataTransfer.files]
                         ~~~~~~~~~~~~~~~~~~~~


Found 8 errors in 7 files.

Errors  Files
     1  app/components/app/annotation/batch-add-annotation-modal/csv-uploader.tsx:51
     1  app/components/app/create-from-dsl-modal/uploader.tsx:61
     1  app/components/apps/hooks/use-dsl-drag-drop.ts:39
     1  app/components/datasets/create-from-pipeline/create-options/create-from-dsl-modal/uploader.tsx:57
     2  app/components/datasets/documents/create-from-pipeline/data-source/local-file/index.tsx:233
     1  app/components/datasets/documents/detail/batch-modal/csv-uploader.tsx:129
     1  app/components/plugins/plugin-page/use-uploader.ts:39
 ELIFECYCLE  Command failed with exit code 1.

Motivation

No response

Additional Context

No response

Originally created by @hyoban on GitHub (Jan 21, 2026). ### Self Checks - [x] I have read the [Contributing Guide](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) and [Language Policy](https://github.com/langgenius/dify/issues/1542). - [x] This is only for refactors or chores; if you would like to ask a question, please head to [Discussions](https://github.com/langgenius/dify/discussions/categories/general). - [x] I have searched for existing issues [search for existing issues](https://github.com/langgenius/dify/issues), including closed ones. - [x] I confirm that I am using English to submit this report, otherwise it will be closed. - [x] 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：） - [x] Please do not modify this template :) and fill in all the required fields. ### Description Now tsc can detect some issues that tsgo cannot. ``` app/components/app/annotation/batch-add-annotation-modal/csv-uploader.tsx:51:23 - error TS2488: Type 'FileList' must have a '[Symbol.iterator]()' method that returns an iterator. 51 const files = [...e.dataTransfer.files] ~~~~~~~~~~~~~~~~~~~~ app/components/app/create-from-dsl-modal/uploader.tsx:61:23 - error TS2488: Type 'FileList' must have a '[Symbol.iterator]()' method that returns an iterator. 61 const files = [...e.dataTransfer.files] ~~~~~~~~~~~~~~~~~~~~ app/components/apps/hooks/use-dsl-drag-drop.ts:39:23 - error TS2488: Type 'FileList' must have a '[Symbol.iterator]()' method that returns an iterator. 39 const files = [...e.dataTransfer.files] ~~~~~~~~~~~~~~~~~~~~ app/components/datasets/create-from-pipeline/create-options/create-from-dsl-modal/uploader.tsx:57:23 - error TS2488: Type 'FileList' must have a '[Symbol.iterator]()' method that returns an iterator. 57 const files = [...e.dataTransfer.files] ~~~~~~~~~~~~~~~~~~~~ app/components/datasets/documents/create-from-pipeline/data-source/local-file/index.tsx:233:21 - error TS2488: Type 'FileList' must have a '[Symbol.iterator]()' method that returns an iterator. 233 let files = [...e.dataTransfer.files] as File[] ~~~~~~~~~~~~~~~~~~~~ app/components/datasets/documents/create-from-pipeline/data-source/local-file/index.tsx:254:21 - error TS2488: Type 'never[] | FileList' must have a '[Symbol.iterator]()' method that returns an iterator. 254 let files = [...(e.target.files ?? [])] as File[] ~~~~~~~~~~~~~~~~~~~~~~ app/components/datasets/documents/detail/batch-modal/csv-uploader.tsx:129:23 - error TS2488: Type 'FileList' must have a '[Symbol.iterator]()' method that returns an iterator. 129 const files = [...e.dataTransfer.files] ~~~~~~~~~~~~~~~~~~~~ app/components/plugins/plugin-page/use-uploader.ts:39:23 - error TS2488: Type 'FileList' must have a '[Symbol.iterator]()' method that returns an iterator. 39 const files = [...e.dataTransfer.files] ~~~~~~~~~~~~~~~~~~~~ Found 8 errors in 7 files. Errors Files 1 app/components/app/annotation/batch-add-annotation-modal/csv-uploader.tsx:51 1 app/components/app/create-from-dsl-modal/uploader.tsx:61 1 app/components/apps/hooks/use-dsl-drag-drop.ts:39 1 app/components/datasets/create-from-pipeline/create-options/create-from-dsl-modal/uploader.tsx:57 2 app/components/datasets/documents/create-from-pipeline/data-source/local-file/index.tsx:233 1 app/components/datasets/documents/detail/batch-modal/csv-uploader.tsx:129 1 app/components/plugins/plugin-page/use-uploader.ts:39  ELIFECYCLE  Command failed with exit code 1. ``` ### Motivation _No response_ ### Additional Context _No response_
yindo added the good first issuestatus: accepting prs labels 2026-02-21 20:14:24 -05:00
yindo closed this issue 2026-02-21 20:14:24 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label good first issue status: accepting prs
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#21808
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?