langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

if missing a branch #22008

New Issue
Closed
opened 2026-02-21 20:15:14 -05:00 by yindo · 5 comments
yindo commented 2026-02-21 20:15:14 -05:00
Owner
Copy Link
Copy Source

Originally created by @asukaminato0721 on GitHub (Feb 1, 2026).

Self Checks

  • I have read the Contributing Guide and Language Policy.
  • This is only for bug report, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：）
  • Please do not modify this template :) and fill in all the required fields.

Dify version

master

Cloud or Self Hosted

Self Hosted (Source)

Steps to reproduce

        if args.annotation_status == "annotated":
            query = query.options(joinedload(Conversation.message_annotations)).join(  # type: ignore
                MessageAnnotation, MessageAnnotation.conversation_id == Conversation.id
            )
        elif args.annotation_status == "not_annotated":
            query = (
                query.outerjoin(MessageAnnotation, MessageAnnotation.conversation_id == Conversation.id)
                .group_by(Conversation.id)
                .having(func.count(MessageAnnotation.id) == 0)
            )

but missing a "all" here

✔️ Expected Behavior

not missing it

❌ Actual Behavior

No response

Originally created by @asukaminato0721 on GitHub (Feb 1, 2026). ### Self Checks - [x] I have read the [Contributing Guide](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) and [Language Policy](https://github.com/langgenius/dify/issues/1542). - [x] This is only for bug report, if you would like to ask a question, please head to [Discussions](https://github.com/langgenius/dify/discussions/categories/general). - [x] I have searched for existing issues [search for existing issues](https://github.com/langgenius/dify/issues), including closed ones. - [x] I confirm that I am using English to submit this report, otherwise it will be closed. - [x] 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：） - [x] Please do not modify this template :) and fill in all the required fields. ### Dify version master ### Cloud or Self Hosted Self Hosted (Source) ### Steps to reproduce ``` if args.annotation_status == "annotated": query = query.options(joinedload(Conversation.message_annotations)).join( # type: ignore MessageAnnotation, MessageAnnotation.conversation_id == Conversation.id ) elif args.annotation_status == "not_annotated": query = ( query.outerjoin(MessageAnnotation, MessageAnnotation.conversation_id == Conversation.id) .group_by(Conversation.id) .having(func.count(MessageAnnotation.id) == 0) ) ``` but missing a "all" here ### ✔️ Expected Behavior not missing it ### ❌ Actual Behavior _No response_
yindo closed this issue 2026-02-21 20:15:14 -05:00
yindo commented 2026-02-21 20:15:15 -05:00
Author
Owner
Copy Link
Copy Source

@dosubot[bot] commented on GitHub (Feb 1, 2026):

The code for filtering conversations by annotation status is in api/controllers/console/app/conversation.py. In both the "annotated" and "not_annotated" branches, the query is not finalized with .all(), but instead is passed to db.paginate(), which handles query execution and pagination internally. In this context, adding .all() is not necessary and could actually interfere with pagination, since db.paginate() expects a query object, not a list of results. So, the current implementation is intentional and correct for paginated endpoints—no .all() is needed here.
See code reference

To reply, just mention @dosu.

How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other

Chat with Dosu Open in Cursor Join Discord Share on X

@dosubot[bot] commented on GitHub (Feb 1, 2026): <!-- Answer --> The code for filtering conversations by annotation status is in `api/controllers/console/app/conversation.py`. In both the "annotated" and "not_annotated" branches, the query is not finalized with `.all()`, but instead is passed to `db.paginate()`, which handles query execution and pagination internally. In this context, adding `.all()` is not necessary and could actually interfere with pagination, since `db.paginate()` expects a query object, not a list of results. So, the current implementation is intentional and correct for paginated endpoints—no `.all()` is needed here. [See code reference](https://github.com/langgenius/dify/blob/3216b67bfa93417814dbdf05fd8d0e174df3c627/api/controllers/console/app/conversation.py#L377-L390) <!-- Dosu Comment Footer --> *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).* --- <sup>How did I do? [Good](https://app.dosu.dev/response-feedback/ed898b7e-b551-4b73-a4ae-8e88e635b2d4?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/ed898b7e-b551-4b73-a4ae-8e88e635b2d4?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/ed898b7e-b551-4b73-a4ae-8e88e635b2d4?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/ed898b7e-b551-4b73-a4ae-8e88e635b2d4?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/ed898b7e-b551-4b73-a4ae-8e88e635b2d4?feedback_type=hallucination) | [Report 🐛](https://app.dosu.dev/response-feedback/ed898b7e-b551-4b73-a4ae-8e88e635b2d4?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/ed898b7e-b551-4b73-a4ae-8e88e635b2d4?feedback_type=other)</sup> [![Chat with Dosu](https://dosu.dev/dosu-chat-badge.svg)](https://app.dosu.dev/6088a4f4-073a-43f3-b3d4-4f06fb0c05a0/ask?utm_source=github)&nbsp;[![Open in Cursor](https://dosu.dev/dosu-in-cursor.svg)](https://cursor.com/link/prompt?text=The%20code%20for%20filtering%20conversations%20by%20annotation%20status%20is%20in%20%60api/controllers/console/app/conversation.py%60.%20In%20both%20the%20%22annotated%22%20and%20%22not_annotated%22%20branches%2C%20the%20query%20is%20not%20finalized%20with%20%60.all%28%29%60%2C%20but%20instead%20is%20passed%20to%20%60db.paginate%28%29%60%2C%20which%20handles%20query%20execution%20and%20pagination%20internally.%20In%20this%20context%2C%20adding%20%60.all%28%29%60%20is%20not%20necessary%20and%20could%20actually%20interfere%20with%20pagination%2C%20since%20%60db.paginate%28%29%60%20expects%20a%20query%20object%2C%20not%20a%20list%20of%20results.%20So%2C%20the%20current%20implementation%20is%20intentional%20and%20correct%20for%20paginated%20endpoints%E2%80%94no%20%60.all%28%29%60%20is%20needed%20here.%20%20%0A%5BSee%20code%20reference%5D%28https%3A//github.com/langgenius/dify/blob/3216b67bfa93417814dbdf05fd8d0e174df3c627/api/controllers/console/app/conversation.py%23L377-L390%29)&nbsp;[![Join Discord](https://img.shields.io/badge/join-5865F2?logo=discord&logoColor=white&label=)](https://go.dosu.dev/discord-bot)&nbsp;[![Share on X](https://img.shields.io/badge/X-share-black)](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/langgenius/dify/issues/31800)
yindo commented 2026-02-21 20:15:15 -05:00
Author
Owner
Copy Link
Copy Source

@asukaminato0721 commented on GitHub (Feb 1, 2026):

@dosu no, I mean args.annotation_status has type

Literal["annotated", "not_annotated", "all"]
@asukaminato0721 commented on GitHub (Feb 1, 2026): @dosu no, I mean args.annotation_status has type ``` Literal["annotated", "not_annotated", "all"] ```
yindo commented 2026-02-21 20:15:15 -05:00
Author
Owner
Copy Link
Copy Source

@dosubot[bot] commented on GitHub (Feb 1, 2026):

The code intentionally handles annotation_status == "all" by not applying any annotation-related filters—so when "all" is selected, the query just returns all conversations, regardless of annotation status. This is consistent in both CompletionConversationApi and ChatConversationApi, and matches the standard pattern for this kind of filter: only "annotated" and "not_annotated" get special query logic, while "all" means no filter is applied. No explicit branch for "all" is needed in the code for this behavior to work as intended.
See code reference

To reply, just mention @dosu.

How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other

Chat with Dosu Open in Cursor Join Discord Share on X

@dosubot[bot] commented on GitHub (Feb 1, 2026): <!-- Answer --> The code intentionally handles annotation_status == "all" by not applying any annotation-related filters—so when "all" is selected, the query just returns all conversations, regardless of annotation status. This is consistent in both CompletionConversationApi and ChatConversationApi, and matches the standard pattern for this kind of filter: only "annotated" and "not_annotated" get special query logic, while "all" means no filter is applied. No explicit branch for "all" is needed in the code for this behavior to work as intended. [See code reference](https://github.com/langgenius/dify/blob/3216b67bfa93417814dbdf05fd8d0e174df3c627/api/controllers/console/app/conversation.py#L32-L520) <!-- Dosu Comment Footer --> *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).* --- <sup>How did I do? [Good](https://app.dosu.dev/response-feedback/d0ae2141-8ca8-4328-b3e4-fa50b03bfcde?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/d0ae2141-8ca8-4328-b3e4-fa50b03bfcde?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/d0ae2141-8ca8-4328-b3e4-fa50b03bfcde?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/d0ae2141-8ca8-4328-b3e4-fa50b03bfcde?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/d0ae2141-8ca8-4328-b3e4-fa50b03bfcde?feedback_type=hallucination) | [Report 🐛](https://app.dosu.dev/response-feedback/d0ae2141-8ca8-4328-b3e4-fa50b03bfcde?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/d0ae2141-8ca8-4328-b3e4-fa50b03bfcde?feedback_type=other)</sup> [![Chat with Dosu](https://dosu.dev/dosu-chat-badge.svg)](https://app.dosu.dev/6088a4f4-073a-43f3-b3d4-4f06fb0c05a0/ask?utm_source=github)&nbsp;[![Open in Cursor](https://dosu.dev/dosu-in-cursor.svg)](https://cursor.com/link/prompt?text=The%20code%20intentionally%20handles%20annotation_status%20%3D%3D%20%22all%22%20by%20not%20applying%20any%20annotation-related%20filters%E2%80%94so%20when%20%22all%22%20is%20selected%2C%20the%20query%20just%20returns%20all%20conversations%2C%20regardless%20of%20annotation%20status.%20This%20is%20consistent%20in%20both%20CompletionConversationApi%20and%20ChatConversationApi%2C%20and%20matches%20the%20standard%20pattern%20for%20this%20kind%20of%20filter%3A%20only%20%22annotated%22%20and%20%22not_annotated%22%20get%20special%20query%20logic%2C%20while%20%22all%22%20means%20no%20filter%20is%20applied.%20No%20explicit%20branch%20for%20%22all%22%20is%20needed%20in%20the%20code%20for%20this%20behavior%20to%20work%20as%20intended.%20%20%0A%5BSee%20code%20reference%5D%28https%3A//github.com/langgenius/dify/blob/3216b67bfa93417814dbdf05fd8d0e174df3c627/api/controllers/console/app/conversation.py%23L32-L520%29)&nbsp;[![Join Discord](https://img.shields.io/badge/join-5865F2?logo=discord&logoColor=white&label=)](https://go.dosu.dev/discord-bot)&nbsp;[![Share on X](https://img.shields.io/badge/X-share-black)](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/langgenius/dify/issues/31800)
yindo commented 2026-02-21 20:15:15 -05:00
Author
Owner
Copy Link
Copy Source

@asukaminato0721 commented on GitHub (Feb 1, 2026):

@dosu so I need to make a case "all": pass branch?

@asukaminato0721 commented on GitHub (Feb 1, 2026): @dosu so I need to make a case "all": pass branch?
yindo commented 2026-02-21 20:15:15 -05:00
Author
Owner
Copy Link
Copy Source

@dosubot[bot] commented on GitHub (Feb 1, 2026):

You don't strictly need an explicit case or branch for "all"—the current logic works as intended because when annotation_status is "all", it just skips the filtering and returns all conversations. This is a common and accepted pattern.

However, if you want to make the code more explicit and future-proof (especially if you or others might add more statuses later), adding a branch like elif annotation_status == "all": pass can improve clarity. Even better, the project is considering moving to Python's match-case for enum handling, which would make missing branches more obvious and help prevent bugs in the future. See the discussion on this direction here.

So: not required, but adding an explicit "all" branch (or switching to match-case) is a good idea for maintainability.

To reply, just mention @dosu.

How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other

Chat with Dosu Open in Cursor Join Discord Share on X

@dosubot[bot] commented on GitHub (Feb 1, 2026): <!-- Answer --> You don't strictly need an explicit case or branch for "all"—the current logic works as intended because when annotation_status is "all", it just skips the filtering and returns all conversations. This is a common and accepted pattern. However, if you want to make the code more explicit and future-proof (especially if you or others might add more statuses later), adding a branch like elif annotation_status == "all": pass can improve clarity. Even better, the project is considering moving to Python's match-case for enum handling, which would make missing branches more obvious and help prevent bugs in the future. See the discussion on this direction [here](https://github.com/langgenius/dify/issues/30001). So: not required, but adding an explicit "all" branch (or switching to match-case) is a good idea for maintainability. <!-- Dosu Comment Footer --> *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).* --- <sup>How did I do? [Good](https://app.dosu.dev/response-feedback/49012a16-f06d-4eae-b757-f5e0a284c935?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/49012a16-f06d-4eae-b757-f5e0a284c935?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/49012a16-f06d-4eae-b757-f5e0a284c935?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/49012a16-f06d-4eae-b757-f5e0a284c935?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/49012a16-f06d-4eae-b757-f5e0a284c935?feedback_type=hallucination) | [Report 🐛](https://app.dosu.dev/response-feedback/49012a16-f06d-4eae-b757-f5e0a284c935?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/49012a16-f06d-4eae-b757-f5e0a284c935?feedback_type=other)</sup> [![Chat with Dosu](https://dosu.dev/dosu-chat-badge.svg)](https://app.dosu.dev/6088a4f4-073a-43f3-b3d4-4f06fb0c05a0/ask?utm_source=github)&nbsp;[![Open in Cursor](https://dosu.dev/dosu-in-cursor.svg)](https://cursor.com/link/prompt?text=You%20don%27t%20strictly%20need%20an%20explicit%20case%20or%20branch%20for%20%22all%22%E2%80%94the%20current%20logic%20works%20as%20intended%20because%20when%20annotation_status%20is%20%22all%22%2C%20it%20just%20skips%20the%20filtering%20and%20returns%20all%20conversations.%20This%20is%20a%20common%20and%20accepted%20pattern.%0A%0AHowever%2C%20if%20you%20want%20to%20make%20the%20code%20more%20explicit%20and%20future-proof%20%28especially%20if%20you%20or%20others%20might%20add%20more%20statuses%20later%29%2C%20adding%20a%20branch%20like%20elif%20annotation_status%20%3D%3D%20%22all%22%3A%20pass%20can%20improve%20clarity.%20Even%20better%2C%20the%20project%20is%20considering%20moving%20to%20Python%27s%20match-case%20for%20enum%20handling%2C%20which%20would%20make%20missing%20branches%20more%20obvious%20and%20help%20prevent%20bugs%20in%20the%20future.%20See%20the%20discussion%20on%20this%20direction%20%5Bhere%5D%28https%3A//github.com/langgenius/dify/issues/30001%29.%0A%0ASo%3A%20not%20required%2C%20but%20adding%20an%20explicit%20%22all%22%20branch%20%28or%20switching%20to%20match-case%29%20is%20a%20good%20idea%20for%20maintainability.)&nbsp;[![Join Discord](https://img.shields.io/badge/join-5865F2?logo=discord&logoColor=white&label=)](https://go.dosu.dev/discord-bot)&nbsp;[![Share on X](https://img.shields.io/badge/X-share-black)](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/langgenius/dify/issues/31800)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#22008
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?