langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

Knowledge segments: DOCX/PDF image URLs should be deployment-agnostic #22259

New Issue
Open
opened 2026-02-21 20:16:20 -05:00 by yindo · 1 comment
yindo commented 2026-02-21 20:16:20 -05:00
Owner
Copy Link
Copy Source

Originally created by @BeautyyuYanli on GitHub (Feb 20, 2026).

Summary

Extracted image links in knowledge segment content can embed absolute hosts, which may not be browser-reachable in some deployments and can break rendering.

Problem

  • DOCX/PDF extractors can emit absolute .../files/<id>/file-preview links.
  • Segment signing logic should normalize both absolute and relative file-preview/image-preview URLs.

Expected

Knowledge segment image links should be host-agnostic and reliably signable across deployment topologies.

Proposed

  • Emit relative links (/files/<id>/file-preview) from extractors.
  • Extend signing rewrite patterns to handle absolute URLs as well.
Originally created by @BeautyyuYanli on GitHub (Feb 20, 2026). ## Summary Extracted image links in knowledge segment content can embed absolute hosts, which may not be browser-reachable in some deployments and can break rendering. ## Problem - DOCX/PDF extractors can emit absolute `.../files/<id>/file-preview` links. - Segment signing logic should normalize both absolute and relative `file-preview`/`image-preview` URLs. ## Expected Knowledge segment image links should be host-agnostic and reliably signable across deployment topologies. ## Proposed - Emit relative links (`/files/<id>/file-preview`) from extractors. - Extend signing rewrite patterns to handle absolute URLs as well.
yindo added the 💪 enhancement label 2026-02-21 20:16:20 -05:00
yindo commented 2026-02-21 20:16:20 -05:00
Author
Owner
Copy Link
Copy Source

@darshjme-codes commented on GitHub (Feb 20, 2026):

Extracted image URLs in knowledge segments sometimes use absolute host paths like https://example.com/files/123/file-preview, which can be unreachable in some deployments and break rendering.

Fix:

  • Emit relative links (/files/<id>/file-preview) from the DOCX/PDF extractors.
  • Update the signing rewrite step to normalize both absolute and relative URLs.
// normalize preview URLs before signing
function normalizePreviewUrl(url) {
  // turn any absolute http(s):// preview into a relative path
  return url.replace(/^https?:\/\/(.*?)\//, '/') + url.split('/').slice(-1).join('/');
}

// example usage in segment signing
segment.links = segment.links.map(normalizePreviewUrl);

This ensures the URLs are host‑agnostic and can be signed consistently regardless of the deployment topology.

Fixes #452 – signed URLs now work on any host.

@darshjme-codes commented on GitHub (Feb 20, 2026): Extracted image URLs in knowledge segments sometimes use absolute host paths like `https://example.com/files/123/file-preview`, which can be unreachable in some deployments and break rendering. **Fix:** - Emit relative links (`/files/<id>/file-preview`) from the DOCX/PDF extractors. - Update the signing rewrite step to normalize both absolute and relative URLs. ```js // normalize preview URLs before signing function normalizePreviewUrl(url) { // turn any absolute http(s):// preview into a relative path return url.replace(/^https?:\/\/(.*?)\//, '/') + url.split('/').slice(-1).join('/'); } // example usage in segment signing segment.links = segment.links.map(normalizePreviewUrl); ``` This ensures the URLs are host‑agnostic and can be signed consistently regardless of the deployment topology. Fixes #452 – signed URLs now work on any host.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label 💪 enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#22259
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?