langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #94] [MERGED] Fix the email validation problem for a.b@c.club. #22305

New Issue
Closed
opened 2026-02-21 20:18:40 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:18:40 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify/pull/94
Author: @hengqujushi
Created: 5/18/2023
Status: ✅ Merged
Merged: 5/21/2023
Merged by: @iamjoel

Base: main ← Head: main

📝 Commits (2)

  • 087bc27 fix: Fix the email validation problem for a.b@c.club.
  • 3565023 fix the problem of bad character range \w-. at position 2

📊 Changes

4 files changed (+4 additions, -4 deletions)

View changed files

📝 api/libs/helper.py (+1 -1)
📝 web/app/install/installForm.tsx (+1 -1)
📝 web/app/signin/normalForm.tsx (+1 -1)
📝 web/config/index.ts (+1 -1)

📄 Description

There are two points in the email verification logic that are easily overlooked. Firstly, the username before the "@" symbol can include not only the conventional requirements of uppercase and lowercase letters, numbers, and underscores for variable naming, but also support "-" and "." symbols. Secondly, the domain name after the "@" symbol needs to meet the first point and also support multiple levels of domains, with the top-level domain being 2 to 4 characters long and typically ending in "io," "org," "club," etc. A good test case is the email address "abc.def@alibaba-inc.com" from Alibaba Group.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify/pull/94 **Author:** [@hengqujushi](https://github.com/hengqujushi) **Created:** 5/18/2023 **Status:** ✅ Merged **Merged:** 5/21/2023 **Merged by:** [@iamjoel](https://github.com/iamjoel) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`087bc27`](https://github.com/langgenius/dify/commit/087bc2736835b72a7ac699791fbbd2831c96b5be) fix: Fix the email validation problem for a.b@c.club. - [`3565023`](https://github.com/langgenius/dify/commit/3565023109a498588ac31d2e31103be181da00bf) fix the problem of bad character range \w-. at position 2 ### 📊 Changes **4 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `api/libs/helper.py` (+1 -1) 📝 `web/app/install/installForm.tsx` (+1 -1) 📝 `web/app/signin/normalForm.tsx` (+1 -1) 📝 `web/config/index.ts` (+1 -1) </details> ### 📄 Description There are two points in the email verification logic that are easily overlooked. Firstly, the username before the "@" symbol can include not only the conventional requirements of uppercase and lowercase letters, numbers, and underscores for variable naming, but also support "-" and "." symbols. Secondly, the domain name after the "@" symbol needs to meet the first point and also support multiple levels of domains, with the top-level domain being 2 to 4 characters long and typically ending in "io," "org," "club," etc. A good test case is the email address "[abc.def@alibaba-inc.com](mailto:abc.def@alibaba-inc.com)" from Alibaba Group. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-21 20:18:40 -05:00
yindo closed this issue 2026-02-21 20:18:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#22305
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?