langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #796] [MERGED] fix bug desc/copyright/privacy_policy none #22692

New Issue
Closed
opened 2026-02-21 20:19:32 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:19:32 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify/pull/796
Author: @lingfengchencn
Created: 8/10/2023
Status: ✅ Merged
Merged: 8/11/2023
Merged by: @crazywoola

Base: main ← Head: fix/add_recommendedapps

📝 Commits (1)

  • aaed911 fix bug desc/copyright/privacy_policy none

📊 Changes

1 file changed (+7 additions, -5 deletions)

View changed files

📝 api/controllers/console/admin.py (+7 -5)

📄 Description

orgin code will cause None value,when site description is None, test codes:

site_desc = 'site_desc'
args_desc = 'args_desc'
result = site_desc if (site_desc if not args_desc else args_desc) else 'else_value'
print(f'{site_desc},{args_desc} => {result}')

site_desc = None
args_desc = 'args_desc'
result = site_desc if (site_desc if not args_desc else args_desc) else 'else_value'
print(f'{site_desc},{args_desc} => {result}')

site_desc = 'site_desc'
args_desc = None
result = site_desc if (site_desc if not args_desc else args_desc) else 'else_value'
print(f'{site_desc},{args_desc} => {result}')

site_desc = None
args_desc = None
result = site_desc if (site_desc if not args_desc else args_desc) else 'else_value'
print(f'{site_desc},{args_desc} => {result}')

result:

site_desc,args_desc => site_desc
None,args_desc => None
site_desc,None => site_desc
None,None => else_value

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify/pull/796 **Author:** [@lingfengchencn](https://github.com/lingfengchencn) **Created:** 8/10/2023 **Status:** ✅ Merged **Merged:** 8/11/2023 **Merged by:** [@crazywoola](https://github.com/crazywoola) **Base:** `main` ← **Head:** `fix/add_recommendedapps` --- ### 📝 Commits (1) - [`aaed911`](https://github.com/langgenius/dify/commit/aaed911bf6f473eba3229dcd20f71272fa961f27) fix bug desc/copyright/privacy_policy none ### 📊 Changes **1 file changed** (+7 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `api/controllers/console/admin.py` (+7 -5) </details> ### 📄 Description orgin code will cause None value,when site description is `None`, test codes: ```python site_desc = 'site_desc' args_desc = 'args_desc' result = site_desc if (site_desc if not args_desc else args_desc) else 'else_value' print(f'{site_desc},{args_desc} => {result}') site_desc = None args_desc = 'args_desc' result = site_desc if (site_desc if not args_desc else args_desc) else 'else_value' print(f'{site_desc},{args_desc} => {result}') site_desc = 'site_desc' args_desc = None result = site_desc if (site_desc if not args_desc else args_desc) else 'else_value' print(f'{site_desc},{args_desc} => {result}') site_desc = None args_desc = None result = site_desc if (site_desc if not args_desc else args_desc) else 'else_value' print(f'{site_desc},{args_desc} => {result}') ``` result: ``` site_desc,args_desc => site_desc None,args_desc => None site_desc,None => site_desc None,None => else_value ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-21 20:19:32 -05:00
yindo closed this issue 2026-02-21 20:19:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#22692
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?