langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #1043] [MERGED] Fix/ignore economy dataset #22855

New Issue
Closed
opened 2026-02-21 20:19:54 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:19:54 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify/pull/1043
Author: @JohnJyong
Created: 8/28/2023
Status: ✅ Merged
Merged: 8/28/2023
Merged by: @JohnJyong

Base: main ← Head: fix/ignore-economy-dataset

📝 Commits (9)

  • caaa72d check dataset model setting is available
  • e7fae0d check dataset model setting is available
  • f29bf72 check dataset model setting is available
  • d8f48f9 check dataset model setting is available
  • 8c2293e check dataset model setting is available
  • 4de0d4a check dataset model setting is available
  • e4b727c Merge branch 'main' into fix/ignore-economy-dataset
  • 08921c8 check dataset model setting is available
  • 32291eb check dataset model setting is available

📊 Changes

13 files changed (+320 additions, -205 deletions)

View changed files

📝 api/controllers/console/datasets/datasets.py (+17 -14)
📝 api/controllers/console/datasets/datasets_document.py (+23 -23)
📝 api/controllers/console/datasets/datasets_segments.py (+48 -53)
📝 api/core/docstore/dataset_docstore.py (+8 -7)
📝 api/core/index/index.py (+18 -1)
📝 api/core/indexing_runner.py (+46 -38)
📝 api/events/event_handlers/create_document_index.py (+0 -1)
➕ api/migrations/versions/4bcffcd64aa4_update_dataset_model_field_null_.py (+46 -0)
📝 api/models/dataset.py (+2 -4)
📝 api/services/dataset_service.py (+99 -55)
📝 api/tasks/batch_create_segment_to_index_task.py (+7 -5)
📝 api/tasks/clean_dataset_task.py (+4 -2)
📝 api/tasks/deal_dataset_vector_index_task.py (+2 -2)

📄 Description

ignore economy dataset embedding model check when embedding model setting is not available

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify/pull/1043 **Author:** [@JohnJyong](https://github.com/JohnJyong) **Created:** 8/28/2023 **Status:** ✅ Merged **Merged:** 8/28/2023 **Merged by:** [@JohnJyong](https://github.com/JohnJyong) **Base:** `main` ← **Head:** `fix/ignore-economy-dataset` --- ### 📝 Commits (9) - [`caaa72d`](https://github.com/langgenius/dify/commit/caaa72d0d4047603a9fde69449f1084e720e4a68) check dataset model setting is available - [`e7fae0d`](https://github.com/langgenius/dify/commit/e7fae0d823d7e46742a95270a273647caea46c1a) check dataset model setting is available - [`f29bf72`](https://github.com/langgenius/dify/commit/f29bf7250e158a26ed57d91606624dabfd5ee437) check dataset model setting is available - [`d8f48f9`](https://github.com/langgenius/dify/commit/d8f48f9cf6889c37acfc74fcae847cef52d022e0) check dataset model setting is available - [`8c2293e`](https://github.com/langgenius/dify/commit/8c2293e6bee8d3099558fab0f6cc577663889d0d) check dataset model setting is available - [`4de0d4a`](https://github.com/langgenius/dify/commit/4de0d4a1d921490a0e59e08e5cd0c824d9975b9e) check dataset model setting is available - [`e4b727c`](https://github.com/langgenius/dify/commit/e4b727c4eff7d8736b22360154fb0061c777e3b5) Merge branch 'main' into fix/ignore-economy-dataset - [`08921c8`](https://github.com/langgenius/dify/commit/08921c8dfbe5cf69487631aaed894a4165f34089) check dataset model setting is available - [`32291eb`](https://github.com/langgenius/dify/commit/32291eb37e0cfa066e3d81f748ae80bbe63299ec) check dataset model setting is available ### 📊 Changes **13 files changed** (+320 additions, -205 deletions) <details> <summary>View changed files</summary> 📝 `api/controllers/console/datasets/datasets.py` (+17 -14) 📝 `api/controllers/console/datasets/datasets_document.py` (+23 -23) 📝 `api/controllers/console/datasets/datasets_segments.py` (+48 -53) 📝 `api/core/docstore/dataset_docstore.py` (+8 -7) 📝 `api/core/index/index.py` (+18 -1) 📝 `api/core/indexing_runner.py` (+46 -38) 📝 `api/events/event_handlers/create_document_index.py` (+0 -1) ➕ `api/migrations/versions/4bcffcd64aa4_update_dataset_model_field_null_.py` (+46 -0) 📝 `api/models/dataset.py` (+2 -4) 📝 `api/services/dataset_service.py` (+99 -55) 📝 `api/tasks/batch_create_segment_to_index_task.py` (+7 -5) 📝 `api/tasks/clean_dataset_task.py` (+4 -2) 📝 `api/tasks/deal_dataset_vector_index_task.py` (+2 -2) </details> ### 📄 Description ignore economy dataset embedding model check when embedding model setting is not available --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-21 20:19:54 -05:00
yindo closed this issue 2026-02-21 20:19:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#22855
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?