langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-24 04:25:01 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #1055] [MERGED] Fix: disable operations of dataset when embedding unavailable #22865

New Issue
Closed
opened 2026-02-21 20:19:55 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:19:55 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify/pull/1055
Author: @JzoNgKVO
Created: 8/30/2023
Status: ✅ Merged
Merged: 8/30/2023
Merged by: @JohnJyong

Base: main ← Head: fix/dataset-embedding-unavailable-operations

📝 Commits (4)

  • cb5e39f fix: style of dataset
  • 8332763 feat: disable operations when dataset embedding unavailable
  • ff25579 dataset embedding setting
  • d64a625 feat: disable dataset settings when embedding unavailable

📊 Changes

16 files changed (+401 additions, -287 deletions)

View changed files

📝 api/controllers/console/datasets/datasets.py (+17 -3)
📝 api/services/dataset_service.py (+13 -9)
📝 web/app/components/app/configuration/dataset-config/card-item/index.tsx (+1 -1)
📝 web/app/components/datasets/documents/detail/completed/InfiniteVirtualList.tsx (+4 -2)
📝 web/app/components/datasets/documents/detail/completed/SegmentCard.tsx (+22 -18)
📝 web/app/components/datasets/documents/detail/completed/index.tsx (+20 -10)
📝 web/app/components/datasets/documents/detail/index.tsx (+6 -1)
📝 web/app/components/datasets/documents/index.tsx (+12 -12)
📝 web/app/components/datasets/documents/list.tsx (+87 -77)
📝 web/app/components/datasets/hit-testing/index.tsx (+91 -81)
📝 web/app/components/datasets/settings/form/index.tsx (+59 -50)
📝 web/app/components/datasets/settings/index-method-radio/index.module.css (+17 -1)
📝 web/app/components/datasets/settings/index-method-radio/index.tsx (+16 -10)
📝 web/app/components/datasets/settings/permissions-radio/index.module.css (+16 -0)
📝 web/app/components/datasets/settings/permissions-radio/index.tsx (+17 -11)
📝 web/i18n/i18next-config.ts (+3 -1)

📄 Description

No description provided

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify/pull/1055 **Author:** [@JzoNgKVO](https://github.com/JzoNgKVO) **Created:** 8/30/2023 **Status:** ✅ Merged **Merged:** 8/30/2023 **Merged by:** [@JohnJyong](https://github.com/JohnJyong) **Base:** `main` ← **Head:** `fix/dataset-embedding-unavailable-operations` --- ### 📝 Commits (4) - [`cb5e39f`](https://github.com/langgenius/dify/commit/cb5e39f0d15717920c57669f476bb658918ca598) fix: style of dataset - [`8332763`](https://github.com/langgenius/dify/commit/83327630eb335427e0237b4f61c8a8fe18f6c4f4) feat: disable operations when dataset embedding unavailable - [`ff25579`](https://github.com/langgenius/dify/commit/ff25579a613b033942da354f27f7ff99359dc2ba) dataset embedding setting - [`d64a625`](https://github.com/langgenius/dify/commit/d64a62589f16c7a9a3e34e87cf7fa8831ec50e0f) feat: disable dataset settings when embedding unavailable ### 📊 Changes **16 files changed** (+401 additions, -287 deletions) <details> <summary>View changed files</summary> 📝 `api/controllers/console/datasets/datasets.py` (+17 -3) 📝 `api/services/dataset_service.py` (+13 -9) 📝 `web/app/components/app/configuration/dataset-config/card-item/index.tsx` (+1 -1) 📝 `web/app/components/datasets/documents/detail/completed/InfiniteVirtualList.tsx` (+4 -2) 📝 `web/app/components/datasets/documents/detail/completed/SegmentCard.tsx` (+22 -18) 📝 `web/app/components/datasets/documents/detail/completed/index.tsx` (+20 -10) 📝 `web/app/components/datasets/documents/detail/index.tsx` (+6 -1) 📝 `web/app/components/datasets/documents/index.tsx` (+12 -12) 📝 `web/app/components/datasets/documents/list.tsx` (+87 -77) 📝 `web/app/components/datasets/hit-testing/index.tsx` (+91 -81) 📝 `web/app/components/datasets/settings/form/index.tsx` (+59 -50) 📝 `web/app/components/datasets/settings/index-method-radio/index.module.css` (+17 -1) 📝 `web/app/components/datasets/settings/index-method-radio/index.tsx` (+16 -10) 📝 `web/app/components/datasets/settings/permissions-radio/index.module.css` (+16 -0) 📝 `web/app/components/datasets/settings/permissions-radio/index.tsx` (+17 -11) 📝 `web/i18n/i18next-config.ts` (+3 -1) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-21 20:19:55 -05:00
yindo closed this issue 2026-02-21 20:19:55 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#22865
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?