langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-22 04:25:29 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #1325] [MERGED] Feat/improve document delete logic #23010

New Issue
Closed
opened 2026-02-21 20:20:15 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:20:15 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/langgenius/dify/pull/1325
Author: @JohnJyong
Created: 10/12/2023
Status: ✅ Merged
Merged: 10/12/2023
Merged by: @JohnJyong

Base: main ← Head: feat/improve-document-delete-logic

📝 Commits (2)

  • 9210ae8 improve document delete logic
  • 09d8418 improve document delete logic

📊 Changes

4 files changed (+34 additions, -26 deletions)

View changed files

📝 api/core/indexing_runner.py (+14 -3)
📝 api/services/dataset_service.py (+0 -3)
📝 api/tasks/clean_document_task.py (+15 -13)
📝 api/tasks/document_indexing_task.py (+5 -7)

📄 Description

enable delete document at any status

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/dify/pull/1325 **Author:** [@JohnJyong](https://github.com/JohnJyong) **Created:** 10/12/2023 **Status:** ✅ Merged **Merged:** 10/12/2023 **Merged by:** [@JohnJyong](https://github.com/JohnJyong) **Base:** `main` ← **Head:** `feat/improve-document-delete-logic` --- ### 📝 Commits (2) - [`9210ae8`](https://github.com/langgenius/dify/commit/9210ae864b62f40a27b2ce71d2e2176f3dfc01f0) improve document delete logic - [`09d8418`](https://github.com/langgenius/dify/commit/09d841864ee7184605d7997ebadf1fa2ad17cac5) improve document delete logic ### 📊 Changes **4 files changed** (+34 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `api/core/indexing_runner.py` (+14 -3) 📝 `api/services/dataset_service.py` (+0 -3) 📝 `api/tasks/clean_document_task.py` (+15 -13) 📝 `api/tasks/document_indexing_task.py` (+5 -7) </details> ### 📄 Description enable delete document at any status --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-21 20:20:15 -05:00
yindo closed this issue 2026-02-21 20:20:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#23010
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?