langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-22 04:25:29 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #2231] fix: occasional multiple responses displayed in frontend due to unexpected message_id from onData #23510

New Issue
Closed
opened 2026-02-21 20:21:13 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:21:13 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/2231

State: closed
Merged: Yes

The error shows as follows:
image

The fundamental cause of the error is that the content returned from the tool call fails to be parsed by JSON.parse in the frontend, resulting in the unexpected creation of two chatLists.

This issue can be divided into two parts:

  1. How to prevent problems with the content returned by the tool, such as encoding format issues
  2. Ensuring that even if the content returned by the tool is problematic, it does not result in disordered display in the frontend.

This PR is focus on the second part, as sometimes the content returned by the tool is unpredictable.

Specifically, this issue is triggered through the following steps:

  1. The result of the Tool call is written into the agent_thought observation and sent to the frontend in stream mode.
  2. Due to unknown reasons, the stream json parsing fails, triggering the following error.
SyntaxError: Bad Unicode escape in JSON at position 12276 (line 1 column 12277)

image

  1. At this point, onData returns bufferObj?.id, which is the thought id.
  2. This id is different from the previous thought.message_id getting from onThought, leading to the introduction of an additional chatList.

In summary, my proposal is to change bufferObj?.id to bufferObj?.message_id.
This change will prevent the misuse of thought_id as message_id.

**Original Pull Request:** https://github.com/langgenius/dify/pull/2231 **State:** closed **Merged:** Yes --- The error shows as follows: ![image](https://github.com/langgenius/dify/assets/5317425/81f417ba-2a65-4b5d-b143-0e233ebe453c) The fundamental cause of the error is that the content returned from the tool call fails to be parsed by `JSON.parse` in the frontend, resulting in the unexpected creation of two chatLists. ------ This issue can be divided into two parts: 1) How to prevent problems with the content returned by the tool, such as encoding format issues 2) Ensuring that even if the content returned by the tool is problematic, it does not result in disordered display in the frontend. **This PR is focus on the second part**, as sometimes the content returned by the tool is unpredictable. ----- Specifically, this issue is triggered through the following steps: 1. The result of the Tool call is written into the `agent_thought` `observation` and sent to the frontend in stream mode. 2. Due to unknown reasons, the stream json parsing fails, triggering the following error. ``` SyntaxError: Bad Unicode escape in JSON at position 12276 (line 1 column 12277) ``` ![image](https://github.com/langgenius/dify/assets/5317425/8275ad66-902e-4e47-84fc-1fe2edc316ed) 3. At this point, `onData` returns **`bufferObj?.id`**, which is the **`thought id`**. 4. This id is different from the previous **`thought.message_id`** getting from **`onThought`**, leading to the introduction of an additional chatList. ----- In summary, my proposal is to change `bufferObj?.id` to `bufferObj?.message_id`. This change will prevent the misuse of `thought_id` as `message_id`.
yindo added the pull-request label 2026-02-21 20:21:13 -05:00
yindo closed this issue 2026-02-21 20:21:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#23510
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?