langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #2420] chore: apply ruff's pyflakes linter rules #23632

New Issue
Closed
opened 2026-02-21 20:21:28 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:21:28 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/2420

State: closed
Merged: Yes

error = ('Invalid {arg}: {val}. {arg} must be conform to the format {format}'
              .format(arg=self.argument, val=value, format=self.format))
  • flattern unnecessary string formatting into static stirngs
  • ignoring the following rules
    • to allow star imports
      • F403: undefined-local-with-import-star
      • F405: undefined-local-with-import-star-usage
    • to allow undefined name, F821, for the class method returning types of the class itself, e.g. 
      class PromptType:
 @classmethod
    def value_of(cls, value: str) -> 'PromptType':
    • to allow unused variable, F841
**Original Pull Request:** https://github.com/langgenius/dify/pull/2420 **State:** closed **Merged:** Yes --- - `pyflake` rules in ruff: https://docs.astral.sh/ruff/rules/#pyflakes-f - fix 1 missing placeholder `format` for format string in `libs/helper` ``` error = ('Invalid {arg}: {val}. {arg} must be conform to the format {format}' .format(arg=self.argument, val=value, format=self.format)) ``` - flattern unnecessary string formatting into static stirngs - ignoring the following rules - to allow star imports - F403: undefined-local-with-import-star - F405: undefined-local-with-import-star-usage - to allow undefined name, F821, for the class method returning types of the class itself, e.g. ``` class PromptType: @classmethod def value_of(cls, value: str) -> 'PromptType': ``` - to allow unused variable, F841
yindo added the pull-request label 2026-02-21 20:21:28 -05:00
yindo closed this issue 2026-02-21 20:21:28 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#23632
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?